Got it! v2 patches sent to mail list.

From: gaoliming [mailto:gaolim...@byosoft.com.cn]
Sent: Wednesday, September 30, 2020 8:59 AM
To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) 
<abner.ch...@hpe.com>; 'Laszlo Ersek' <ler...@redhat.com>
Cc: Wang, Nickle (HPS SW) <nickle.w...@hpe.com>; 'Andrew Fish' 
<af...@apple.com>; 'Leif Lindholm' <l...@nuviainc.com>; 'Michael D Kinney' 
<michael.d.kin...@intel.com>
Subject: 回复: [edk2-devel] [RedfishPkg PATCH 4/4] edk2: Add maintainers to 
RedfishPkg

Yes. Maintainer has the both role of reviewer and patch merge.

Thanks
Liming

发件人: 
bounce+27952+65723+4905953+8761...@groups.io<mailto:bounce+27952+65723+4905953+8761...@groups.io>
 
<bounce+27952+65723+4905953+8761...@groups.io<mailto:bounce+27952+65723+4905953+8761...@groups.io>>
 代表 Abner Chang
发送时间: 2020年9月29日 19:23
收件人: Laszlo Ersek <ler...@redhat.com<mailto:ler...@redhat.com>>; 
devel@edk2.groups.io<mailto:devel@edk2.groups.io>
抄送: Wang, Nickle (HPS SW) <nickle.w...@hpe.com<mailto:nickle.w...@hpe.com>>; 
Andrew Fish <af...@apple.com<mailto:af...@apple.com>>; Leif Lindholm 
<l...@nuviainc.com<mailto:l...@nuviainc.com>>; Michael D Kinney 
<michael.d.kin...@intel.com<mailto:michael.d.kin...@intel.com>>
主题: Re: [edk2-devel] [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg

Without R, I still can give reviewed-by to others contribute to RedfishPkg 
right?

Get Outlook for Android<https://aka.ms/ghei36>

________________________________
From: Laszlo Ersek <ler...@redhat.com<mailto:ler...@redhat.com>>
Sent: Tuesday, September 29, 2020, 6:42 PM
To: Chang, Abner (HPS SW/FW Technologist); 
devel@edk2.groups.io<mailto:devel@edk2.groups.io>
Cc: Wang, Nickle (HPS SW); Andrew Fish; Leif Lindholm; Michael D Kinney
Subject: Re: [RedfishPkg PATCH 4/4] edk2: Add maintainers to RedfishPkg

On 09/29/20 11:47, changab wrote:
> Signed-off-by: Chang Abner <abner.ch...@hpe.com<mailto:abner.ch...@hpe.com>>
> Cc: Nickle Wang <nickle.w...@hpe.com<mailto:nickle.w...@hpe.com>>
> Cc: Andrew Fish <af...@apple.com<mailto:af...@apple.com>>
> Cc: Laszlo Ersek <ler...@redhat.com<mailto:ler...@redhat.com>>
> Cc: Leif Lindholm <l...@nuviainc.com<mailto:l...@nuviainc.com>>
> Cc: Michael D Kinney 
> <michael.d.kin...@intel.com<mailto:michael.d.kin...@intel.com>>
> ---
>  Maintainers.txt | 6 ++++++
>  1 file changed, 6 insertions(+)
>
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 6a22a14796..cc9d173285 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -503,6 +503,12 @@ F: PcAtChipsetPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg
>  M: Ray Ni <ray...@intel.com<mailto:ray...@intel.com>>
>
> +RedfishPkg: Redfish related modules
> +F: RedfishPkg/
> +M: Abner Chang <abner.ch...@hpe.com<mailto:abner.ch...@hpe.com>>
> +R: Abner Chang <abner.ch...@hpe.com<mailto:abner.ch...@hpe.com>>

I don't think it makes much sense to add Abner as both M and R. I
suggest dropping the R line for Abner.

Thanks
Laszlo


> +R: Nickle Wang <nickle.w...@hpe.com<mailto:nickle.w...@hpe.com>>
> +
>  SecurityPkg
>  F: SecurityPkg/
>  W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
>




-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65754): https://edk2.groups.io/g/devel/message/65754
Mute This Topic: https://groups.io/mt/77210897/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to