On 09/30/20 03:56, changab wrote:
> Initial version of RedfishPkg.
> 
> Signed-off-by: Wu Jiaxin <[email protected]>
> Signed-off-by: Fu Siyuan <[email protected]>
> Signed-off-by: Wang Fan <[email protected]>
> Signed-off-by: Chang Abner <[email protected]>
> Cc: Nickle Wang <[email protected]>
> Cc: Andrew Fish <[email protected]>
> Cc: Laszlo Ersek <[email protected]>
> Cc: Leif Lindholm <[email protected]>
> Cc: Michael D Kinney <[email protected]>
> ---
>  RedfishPkg/RedfishPkg.ci.yaml | 67 +++++++++++++++++++++++++++++++++++
>  RedfishPkg/RedfishPkg.dec     | 18 ++++++++++
>  RedfishPkg/RedfishPkg.dsc     | 40 +++++++++++++++++++++
>  3 files changed, 125 insertions(+)
>  create mode 100644 RedfishPkg/RedfishPkg.ci.yaml
>  create mode 100644 RedfishPkg/RedfishPkg.dec
>  create mode 100644 RedfishPkg/RedfishPkg.dsc

based on the diffstat:

Acked-by: Laszlo Ersek <[email protected]>

However, I suggest resending this series (more precisely, sending a v3).
Here's why:

The patch seems to have been posted "From: changab
<[email protected]>". This will be recorded in the git history, by
git-am. (The mergify bot overwrites the Committer meta-field, but the
Author meta-field remains in place, from git-am -- and that works from
"From:".)

I think "Abner Chang <[email protected]>" looks a whole lot better
than "changab <[email protected]>", in the Author field. So please
rebase this series locally, picking the "edit" action for each patch,
and then re-commit each patch with:

  git commit --amend --author="Abner Chang <[email protected]>"
  git rebase --continue

Additionally, please update the "user.name" knob in your git config.

Sorry for obsessing about this -- I'd really like the git history to
look *nice*.

Thanks
Laszlo



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#65785): https://edk2.groups.io/g/devel/message/65785
Mute This Topic: https://groups.io/mt/77210801/21656
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to