On 01/19/21 02:12, Jiahui Cen via groups.io wrote: > OvmfPkg/PciHostBridgeLib instance fails to list its PcdLib dependency, > both between the #include directives, and in the INF file. So let's list > the dependency. > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3059 > > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com> > Cc: Ard Biesheuvel <ard.biesheu...@arm.com> > Cc: Anthony Perard <anthony.per...@citrix.com> > Cc: Julien Grall <jul...@xen.org> > Signed-off-by: Jiahui Cen <cenjia...@huawei.com> > --- > OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf | 1 + > OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 1 + > OvmfPkg/Library/PciHostBridgeLib/XenSupport.c | 1 + > 3 files changed, 3 insertions(+) > > diff --git a/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf > b/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf > index 4c56f3c90b3b..cec3f1631a72 100644 > --- a/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf > +++ b/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf > @@ -39,6 +39,7 @@ [LibraryClasses] > DebugLib > DevicePathLib > MemoryAllocationLib > + PcdLib > PciHostBridgeUtilityLib > PciLib > QemuFwCfgLib > diff --git a/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c > b/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c > index 4a176347fd49..bf32455b9f0d 100644 > --- a/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c > +++ b/OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c > @@ -19,6 +19,7 @@ > #include <Library/DebugLib.h> > #include <Library/DevicePathLib.h> > #include <Library/MemoryAllocationLib.h> > +#include <Library/PcdLib.h> > #include <Library/PciHostBridgeLib.h> > #include <Library/PciHostBridgeUtilityLib.h> > #include <Library/PciLib.h> > diff --git a/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c > b/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c > index e161f14375ca..95ed0a280b9b 100644 > --- a/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c > +++ b/OvmfPkg/Library/PciHostBridgeLib/XenSupport.c > @@ -17,6 +17,7 @@ > #include <Library/BaseMemoryLib.h> > #include <Library/DebugLib.h> > #include <Library/MemoryAllocationLib.h> > +#include <Library/PcdLib.h> > #include <Library/PciHostBridgeLib.h> > #include <Library/PciLib.h> > #include "PciHostBridge.h" >
At this stage, "XenSupport.c" doesn't seem to call any PcdLib API. But, it's not a big deal. Reviewed-by: Laszlo Ersek <ler...@redhat.com> Thanks, Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70573): https://edk2.groups.io/g/devel/message/70573 Mute This Topic: https://groups.io/mt/79941619/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
