Reviewed-by: Bob Feng <[email protected]<mailto:[email protected]>>
From: [email protected] <[email protected]> On Behalf Of gaoliming Sent: Friday, January 22, 2021 8:27 AM To: [email protected]; [email protected] Cc: Feng, Bob C <[email protected]>; Chen, Christine <[email protected]> Subject: 回复: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/exception: Added _ModuleEntryPoint into exception list Got it. Reviewed-by: Liming Gao <[email protected]<mailto:[email protected]>> Thanks Liming 发件人: [email protected]<mailto:[email protected]> <[email protected]<mailto:[email protected]>> 代表 Kun Qin 发送时间: 2021年1月21日 9:54 收件人: [email protected]<mailto:[email protected]>; [email protected]<mailto:[email protected]> 抄送: 'Bob Feng' <[email protected]<mailto:[email protected]>>; 'Yuwei Chen' <[email protected]<mailto:[email protected]>> 主题: Re: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/exception: Added _ModuleEntryPoint into exception list Hi Liming, It trips on the coding style where “Function name does not follow the rules: 1. First character should be upper case 2. Must contain lower case characters 3. No white space characters”. Please see detailed error info here: https://dev.azure.com/tianocore/edk2-ci/_build/results?buildId=18722&view=logs&j=dc79cb3a-f339-5fc0-73b1-0ff8c522379e&t=b5b21d01-2921-57ea-8401-4c0ebee10613&l=69 This patch ([PATCH v3 02/18] StandaloneMmPkg: StandaloneMmCoreEntryPoint: Extends support for X64 (groups.io)<https://edk2.groups.io/g/devel/message/70332>) added a new instance for StandaloneMmCoreEntryPoint library and failed on ECC check 8006 due to the function name involved. Regards, Kun From: gaoliming<mailto:[email protected]> Sent: Wednesday, January 20, 2021 17:45 To: 'Kun Qin'<mailto:[email protected]>; [email protected]<mailto:[email protected]> Cc: 'Bob Feng'<mailto:[email protected]>; 'Yuwei Chen'<mailto:[email protected]> Subject: 回复: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/exception: Added _ModuleEntryPoint into exception list Qin: This change makes sense. Can you let me know which case trigs this ECC issue? Does your patch include such case? Thanks Liming 发件人: Kun Qin <[email protected]<mailto:[email protected]>> 发送时间: 2021年1月21日 9:37 收件人: [email protected]<mailto:[email protected]> 抄送: Bob Feng <[email protected]<mailto:[email protected]>>; Liming Gao <[email protected]<mailto:[email protected]>>; Yuwei Chen <[email protected]<mailto:[email protected]>> 主题: RE: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/exception: Added _ModuleEntryPoint into exception list Hi Bob/Liming/Yuwei, Do you mind providing some feedback on this patch? This is to unblock the second patch (adding driver entry point instance for Standalone X64) of this patch series. Thanks in advance! Regards, Kun From: Kun Qin<mailto:[email protected]> Sent: Thursday, January 14, 2021 14:34 To: [email protected]<mailto:[email protected]> Cc: Bob Feng<mailto:[email protected]>; Liming Gao<mailto:[email protected]>; Yuwei Chen<mailto:[email protected]> Subject: [edk2-devel] [PATCH v3 01/18] BaseTools: Ecc/exception: Added _ModuleEntryPoint into exception list Function '_ModuleEntryPoint' is a pre-defined interface for various EFI module types and should not be caught violating EFI coding style. This change added '_ModuleEntryPoint' into exception list to fix EFI coding style error 8006 during CI build. Cc: Bob Feng <[email protected]<mailto:[email protected]>> Cc: Liming Gao <[email protected]<mailto:[email protected]>> Cc: Yuwei Chen <[email protected]<mailto:[email protected]>> Signed-off-by: Kun Qin <[email protected]<mailto:[email protected]>> --- Notes: v3: - Newly added to fix CI build on changing '_ModuleEntryPoint' BaseTools/Source/Python/Ecc/exception.xml | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/BaseTools/Source/Python/Ecc/exception.xml b/BaseTools/Source/Python/Ecc/exception.xml index 8133904fbc7f..f2334aab8e52 100644 --- a/BaseTools/Source/Python/Ecc/exception.xml +++ b/BaseTools/Source/Python/Ecc/exception.xml @@ -296,6 +296,10 @@ <KeyWord>_DriverUnloadHandler</KeyWord> <ErrorID>8006</ErrorID> </Exception> + <Exception> + <KeyWord>_ModuleEntryPoint</KeyWord> + <ErrorID>8006</ErrorID> + </Exception> <Exception> <KeyWord>ASSERT</KeyWord> <ErrorID>10015</ErrorID> -- 2.30.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70756): https://edk2.groups.io/g/devel/message/70756 Mute This Topic: https://groups.io/mt/80124793/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
