Reviewed-by: Ray Ni <[email protected]>
> -----Original Message----- > From: Park, Aiden <[email protected]> > Sent: Friday, January 29, 2021 9:55 AM > To: Wu, Hao A <[email protected]>; Ni, Ray <[email protected]>; > [email protected] > Cc: Ma, Maurice <[email protected]>; Dong, Guo <[email protected]> > Subject: RE: [PATCH] MdeModulePkg/PciBusDxe: Fix a bug in > ProcessOptionRomLight > > Hello, > > Can you please review this? > > > -----Original Message----- > > From: Park, Aiden <[email protected]> > > Sent: Wednesday, January 13, 2021 11:01 AM > > To: Wu, Hao A <[email protected]>; Ni, Ray <[email protected]>; > > [email protected] > > Cc: Park, Aiden <[email protected]>; Ma, Maurice > > <[email protected]>; Dong, Guo <[email protected]> > > Subject: [PATCH] MdeModulePkg/PciBusDxe: Fix a bug in > > ProcessOptionRomLight > > > > From: Aiden Park <[email protected]> > > > > The ProcessOptionRomLight() assumes that OpRom has already been processed > > in the previous full enumeration and updates AllOpRomProcessed flag to TRUE > > by default. However, this may not be applicable with other pre-stage boot > > firmwares. > > > > This will update AllOpRomProcessed flag properly by checking > > PciRomGetImageMapping(). > > > > Signed-off-by: Aiden Park <[email protected]> > > --- > > MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c | 7 +------ > > 1 file changed, 1 insertion(+), 6 deletions(-) > > > > diff --git a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c > > b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c > > index 1b64924b7b..e8337e865e 100644 > > --- a/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c > > +++ b/MdeModulePkg/Bus/Pci/PciBusDxe/PciEnumeratorSupport.c > > @@ -1168,12 +1168,7 @@ ProcessOptionRomLight ( > > ProcessOptionRomLight (Temp); > > } > > > > - PciRomGetImageMapping (Temp); > > - > > - // > > - // The OpRom has already been processed in the first round > > - // > > - Temp->AllOpRomProcessed = TRUE; > > + Temp->AllOpRomProcessed = PciRomGetImageMapping (Temp); > > > > CurrentLink = CurrentLink->ForwardLink; > > } > > -- > > 2.20.1 > > Best Regards, > Aiden -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70903): https://edk2.groups.io/g/devel/message/70903 Mute This Topic: https://groups.io/mt/79658545/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
