On 01/30/21 03:18, Laszlo Ersek wrote: > On 01/29/21 01:59, Ankur Arora wrote: >> Process fw_remove events in QemuCpuhpCollectApicIds() and collect >> corresponding APIC IDs for CPUs that are being hot-unplugged. >> >> In addition, we now ignore CPUs which only have remove set. These >> CPUs haven't been processed by OSPM yet. >> >> This is based on the QEMU hot-unplug protocol documented here: >> >> https://lore.kernel.org/qemu-devel/20201204170939.1815522-3-imamm...@redhat.com/ >> >> Also define QEMU_CPUHP_STAT_EJECTED while we are at it. > > (1) Please move the addition of QEMU_CPUHP_STAT_EJECTED to patch 8 > ("OvmfPkg/CpuHotplugSmm: add worker to do CPU ejection"), where you > first use it.
(4) Apologies for the bikeshedding, but I also suggest that we call the macro "QEMU_CPUHP_STAT_EJECT", rather than "_EJECTED". Reason: QEMU documents this bit (on write) as "initiates device eject"; in other words, it's not a status, but a signal (or request) from the guest code to QEMU. Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#70917): https://edk2.groups.io/g/devel/message/70917 Mute This Topic: https://groups.io/mt/80199952/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
