On 02/05/21 10:35, Sheng, W wrote: > Hi Jiewen, Eric, Ray, Rahul, Ersek, > I have updated the patch v2. And all comments are fixed. > Since open CI is using NASM 2.14.02, it has not supported CET instructions > yet. > I would like to use DB xx xx xx xx to replace the assembly instruction before > NASM 2.15.01 is used by open CI. > Could you continue the code review ? > Thank you. > BR > Sheng Wei
I'll let others review this patch. I'm OK to add macros to the nasm.inc files under MdePkg, as wrappers for the DB-encoded CET instructions, as long as you also file a reminder BZ to replace the DBs with the actual instructions, once a CET-supporting NASM becomes available in CI. Thanks Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#71366): https://edk2.groups.io/g/devel/message/71366 Mute This Topic: https://groups.io/mt/80205210/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
