*How* annoying was this?
This is kind of useful information, well at the "would be good to see
in a regular DEBUG build" level.
This change will have suddenly effectively hidden a message that was
already present in many platforms, where they were not (very) annoyingly
repetitive during a normal boot.
It feels the test suite is not the thing that we need to optimise
debug output for.
Is there some alternative way we can rate limit this?
/
Leif
On Sat, Feb 20, 2021 at 17:50:43 +0100, Ard Biesheuvel wrote:
> On Sat, 20 Feb 2021 at 17:41, Samer El-Haj-Mahmoud
> <[email protected]> wrote:
> >
> > the DEBUG message for using compilation time epoch is appearing very
> > frequently on DEBUG firmware builds, for example during UEFI SCT runs.
> > Reduce verbosity to avoid the annoying repetitive message.
> >
> > Cc: Ard Biesheuvel <[email protected]>
> > Cc: Leif Lindholm <[email protected]>
> > Cc: Pete Batard <[email protected]>
> > Signed-off-by: Samer El-Haj-Mahmoud <[email protected]>
>
>
> Reviewed-by: Ard Biesheuvel <[email protected]>
>
> Merged as #1434 into master.
>
> > ---
> > EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c | 2
> > +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git
> > a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c
> > b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c
> > index 5c13ed4cf190..4210708cff36 100644
> > --- a/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c
> > +++ b/EmbeddedPkg/Library/VirtualRealTimeClockLib/VirtualRealTimeClockLib.c
> > @@ -88,7 +88,7 @@ LibGetTime (
> > //
> > EpochSeconds = BUILD_EPOCH;
> > DEBUG ((
> > - DEBUG_INFO,
> > + DEBUG_VERBOSE,
> > "LibGetTime: %s non volatile variable was not found - Using
> > compilation time epoch.\n",
> > mEpochVariableName
> > ));
> > --
> > 2.25.1
> >
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#71884): https://edk2.groups.io/g/devel/message/71884
Mute This Topic: https://groups.io/mt/79110001/21656
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
