Zhiguang: Yes. I can merge part of the patch set, because each patch is for the different platform.
I will wait for one more day for the patch review, and merge the patch tomorrow for those passed code review. Thanks Liming > -----邮件原件----- > 发件人: Liu, Zhiguang <zhiguang....@intel.com> > 发送时间: 2021年3月17日 22:33 > 收件人: Kun Qin <kuqi...@gmail.com>; devel@edk2.groups.io; Liming Gao > <gaolim...@byosoft.com.cn> > 抄送: Chiu, Chasel <chasel.c...@intel.com>; Desimone, Nathaniel L > <nathaniel.l.desim...@intel.com>; Dong, Eric <eric.d...@intel.com> > 主题: RE: [edk2-devel] [edk2-platforms][PATCH v2 1/5] MinPlatformPkg: > CoreCommonLib: Added new library for VariableSmmRuntimeDxe > > Hi Liming, > Can you help merge the first two patches in this patch set? > If you need, I can provide the patch files. > > Hi Kun, > Thanks. Let's see if Liming can help. > > Thanks > Zhiguang > > > -----Original Message----- > > From: Kun Qin <kuqi...@gmail.com> > > Sent: Wednesday, March 17, 2021 4:11 PM > > To: Liu, Zhiguang <zhiguang....@intel.com>; devel@edk2.groups.io > > Cc: Chiu, Chasel <chasel.c...@intel.com>; Desimone, Nathaniel L > > <nathaniel.l.desim...@intel.com>; Liming Gao > > <gaolim...@byosoft.com.cn>; Dong, Eric <eric.d...@intel.com> > > Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 1/5] MinPlatformPkg: > > CoreCommonLib: Added new library for VariableSmmRuntimeDxe > > > > Hi Zhiguang, > > > > I do not mind check the reviewed patches (the first 3 changes, > > specifically) in first. I have not done this before. How you want to > > proceed in > > that case? > > > > Regards, > > Kun > > > > On 03/17/2021 00:52, Liu, Zhiguang wrote: > > > Reviewed-by: Zhiguang Liu <zhiguang....@intel.com> > > > > > > Hi Kun, > > > Since the first two changes about MinPlatformPkg already got reviewed, > > can we first check them in? > > > > > > Thanks > > > Zhiguang > > > > > >> -----Original Message----- > > >> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Kun > > >> Qin > > >> Sent: Wednesday, March 17, 2021 2:11 AM > > >> To: devel@edk2.groups.io > > >> Cc: Chiu, Chasel <chasel.c...@intel.com>; Desimone, Nathaniel L > > >> <nathaniel.l.desim...@intel.com>; Liming Gao > > >> <gaolim...@byosoft.com.cn>; Dong, Eric <eric.d...@intel.com> > > >> Subject: [edk2-devel] [edk2-platforms][PATCH v2 1/5] MinPlatformPkg: > > >> CoreCommonLib: Added new library for VariableSmmRuntimeDxe > > >> > > >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3250 > > >> > > >> This change added NULL MmUnblockMemoryLib instance in dsc files of > > >> CoreCommonLib to resolve newly introduced dependency. The library > > >> interface is consumed by VariableSmmRuntimeDxe to better support > > >> variable runtime cache feature. > > >> > > >> Cc: Chasel Chiu <chasel.c...@intel.com> > > >> Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> > > >> Cc: Liming Gao <gaolim...@byosoft.com.cn> > > >> Cc: Eric Dong <eric.d...@intel.com> > > >> > > >> Signed-off-by: Kun Qin <kuqi...@gmail.com> > > >> Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn> > > >> --- > > >> > > >> Notes: > > >> v2: > > >> - Added reviewed-by tag [Liming] > > >> > > >> Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc | 1 > + > > >> 1 file changed, 1 insertion(+) > > >> > > >> diff --git > > >> a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > > >> b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > > >> index cb40e111b5dd..bcabb797e91a 100644 > > >> --- a/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > > >> +++ b/Platform/Intel/MinPlatformPkg/Include/Dsc/CoreCommonLib.dsc > > >> @@ -159,6 +159,7 @@ [LibraryClasses.common] > > >> > LockBoxLib|MdeModulePkg/Library/LockBoxNullLib/LockBoxNullLib.inf > > >> > > >> SmmMemLib|MdePkg/Library/SmmMemLib/SmmMemLib.inf > > >> + > > >> + > > >> > > > MmUnblockMemoryLib|MdePkg/Library/MmUnblockMemoryLib/MmUnblo > > >> ckMemoryLi > > >> + bNull.inf > > >> > > >> > SmbusLib|MdePkg/Library/BaseSmbusLibNull/BaseSmbusLibNull.inf > > >> > > >> VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePoli > > >> VariablePolicyLib|cyLi > > >> b.inf > > >> -- > > >> 2.30.0.windows.1 > > >> > > >> > > >> > > >> > > >> > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#73003): https://edk2.groups.io/g/devel/message/73003 Mute This Topic: https://groups.io/mt/81422882/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
