Looks like we have the requisite approvals. Shall I create a PR? - Bret
From: Wu, Hao A via groups.io<mailto:hao.a.wu=intel....@groups.io> Sent: Sunday, April 11, 2021 7:23 PM To: Bret Barkelew<mailto:b...@corthon.com>; devel@edk2.groups.io<mailto:devel@edk2.groups.io> Cc: Wang, Jian J<mailto:jian.j.w...@intel.com> Subject: [EXTERNAL] Re: [edk2-devel] [PATCH v1 1/1] MdeModulePkg: Initialize temp variable in VarCheckPolicyLib > -----Original Message----- > From: Bret Barkelew <b...@corthon.com> > Sent: Saturday, April 10, 2021 2:25 AM > To: devel@edk2.groups.io > Cc: Wang, Jian J <jian.j.w...@intel.com>; Wu, Hao A <hao.a...@intel.com> > Subject: [PATCH v1 1/1] MdeModulePkg: Initialize temp variable in > VarCheckPolicyLib > > DumpVariablePolicy() will return EFI_INVALID_PARAMETER if the Buffer > pointer is NULL and the indirect Size is anything but 0. Since this TempSize > was not being initialized it is very likely that this sequence would not > return > the total buffer size as expected. > > Bugzilla: > https://nam06.safelinks.protection.outlook.com/?url=https%3A%2F%2Fbugzilla.tianocore.org%2Fshow_bug.cgi%3Fid%3D3310&data=04%7C01%7Cbret.barkelew%40microsoft.com%7Cdd597013a0874fa676f708d8fd5a02e2%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C637537910324146700%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C1000&sdata=qxCQ6vccJFzG8gH9qDBHD9xnl%2FCs3DdVUuMtHspanfY%3D&reserved=0 > > Cc: Jian J Wang <jian.j.w...@intel.com> > Cc: Hao A Wu <hao.a...@intel.com> > Signed-off-by: Bret Barkelew <bret.barke...@microsoft.com> > --- > MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c > b/MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c > index 14e1904e96d3..e50edb4ffc5a 100644 > --- a/MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c > +++ b/MdeModulePkg/Library/VarCheckPolicyLib/VarCheckPolicyLib.c > @@ -216,6 +216,7 @@ VarCheckPolicyLibMmiHandler ( > DumpParamsOut->TotalSize = 0; > DumpParamsOut->PageSize = 0; > DumpParamsOut->HasMore = FALSE; > + TempSize = 0; > SubCommandStatus = DumpVariablePolicy (NULL, &TempSize); Reviewed-by: Hao A Wu <hao.a...@intel.com> Best Regards, Hao Wu > if (SubCommandStatus == EFI_BUFFER_TOO_SMALL && TempSize > 0) { > mCurrentPaginationCommand = > VAR_CHECK_POLICY_COMMAND_DUMP; > -- > 2.28.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#73967): https://edk2.groups.io/g/devel/message/73967 Mute This Topic: https://groups.io/mt/81976395/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
