On 05/07/21 22:38, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > Version 2 of the GHCB spec introduces several new SNP-specific NAEs. > Unfortunately, the names for those NAEs break the alignment. Add some > white spaces so that the SNP support patches do not break the alignment. > > Cc: James Bottomley <[email protected]> > Cc: Min Xu <[email protected]> > Cc: Jiewen Yao <[email protected]> > Cc: Tom Lendacky <[email protected]> > Cc: Jordan Justen <[email protected]> > Cc: Ard Biesheuvel <[email protected]> > Cc: Laszlo Ersek <[email protected]> > Cc: Erdem Aktas <[email protected]> > Cc: Michael D Kinney <[email protected]> > Cc: Liming Gao <[email protected]> > Cc: Zhiguang Liu <[email protected]> > Signed-off-by: Brijesh Singh <[email protected]> > --- > MdePkg/Include/Register/Amd/Fam17Msr.h | 10 +++++----- > MdePkg/Include/Register/Amd/Ghcb.h | 12 ++++++------ > 2 files changed, 11 insertions(+), 11 deletions(-) > > diff --git a/MdePkg/Include/Register/Amd/Fam17Msr.h > b/MdePkg/Include/Register/Amd/Fam17Msr.h > index 716d52fd508d..7368ce7af02a 100644 > --- a/MdePkg/Include/Register/Amd/Fam17Msr.h > +++ b/MdePkg/Include/Register/Amd/Fam17Msr.h > @@ -53,11 +53,11 @@ typedef union { > UINT64 GhcbPhysicalAddress; > } MSR_SEV_ES_GHCB_REGISTER; > > -#define GHCB_INFO_SEV_INFO 1 > -#define GHCB_INFO_SEV_INFO_GET 2 > -#define GHCB_INFO_CPUID_REQUEST 4 > -#define GHCB_INFO_CPUID_RESPONSE 5 > -#define GHCB_INFO_TERMINATE_REQUEST 256 > +#define GHCB_INFO_SEV_INFO 1 > +#define GHCB_INFO_SEV_INFO_GET 2 > +#define GHCB_INFO_CPUID_REQUEST 4 > +#define GHCB_INFO_CPUID_RESPONSE 5 > +#define GHCB_INFO_TERMINATE_REQUEST 256 > > #define GHCB_TERMINATE_GHCB 0 > #define GHCB_TERMINATE_GHCB_GENERAL 0 > diff --git a/MdePkg/Include/Register/Amd/Ghcb.h > b/MdePkg/Include/Register/Amd/Ghcb.h > index ccdb662af7a7..712dc8e769c0 100644 > --- a/MdePkg/Include/Register/Amd/Ghcb.h > +++ b/MdePkg/Include/Register/Amd/Ghcb.h > @@ -49,12 +49,12 @@ > // > // VMG Special Exit Codes > // > -#define SVM_EXIT_MMIO_READ 0x80000001ULL > -#define SVM_EXIT_MMIO_WRITE 0x80000002ULL > -#define SVM_EXIT_NMI_COMPLETE 0x80000003ULL > -#define SVM_EXIT_AP_RESET_HOLD 0x80000004ULL > -#define SVM_EXIT_AP_JUMP_TABLE 0x80000005ULL > -#define SVM_EXIT_UNSUPPORTED 0x8000FFFFULL > +#define SVM_EXIT_MMIO_READ 0x80000001ULL > +#define SVM_EXIT_MMIO_WRITE 0x80000002ULL > +#define SVM_EXIT_NMI_COMPLETE 0x80000003ULL > +#define SVM_EXIT_AP_RESET_HOLD 0x80000004ULL > +#define SVM_EXIT_AP_JUMP_TABLE 0x80000005ULL > +#define SVM_EXIT_UNSUPPORTED 0x8000FFFFULL > > // > // IOIO Exit Information >
Based on Liming's feedback at <https://listman.redhat.com/archives/edk2-devel-archive/2021-May/msg00157.html>, I'll change the subject of this patch to: MdePkg/Register/Amd: realign macros with more space for future expansion (72 chars) Reviewed-by: Laszlo Ersek <[email protected]> Thanks, Laszlo -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#74959): https://edk2.groups.io/g/devel/message/74959 Mute This Topic: https://groups.io/mt/82665179/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
