Agree this fix. Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn>
> -----邮件原件-----
> 发件人: Walon Li <walon...@hpe.com>
> 发送时间: 2021年5月13日 10:49
> 收件人: devel@edk2.groups.io
> 抄送: walon...@hpe.com; nickle.w...@hpe.com; dandan...@intel.com;
> gaolim...@byosoft.com.cn
> 主题: [PATCH] MdeModulePkg/PlatformDriOverrideDxe: Fix overflow
> condition check
>
> Code mistake, VariableIndex is smaller normally than buffer+buffersize
> so should not break loop.
>
> Signed-off-by:Walon Li <walon...@hpe.com>
> ---
> .../Universal/PlatformDriOverrideDxe/PlatDriOverrideLib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/MdeModulePkg/Universal/PlatformDriOverrideDxe/PlatDriOverrideLib.c
> b/MdeModulePkg/Universal/PlatformDriOverrideDxe/PlatDriOverrideLib.c
> index f91f038b7a..bd2d04452f 100644
> --- a/MdeModulePkg/Universal/PlatformDriOverrideDxe/PlatDriOverrideLib.c
> +++
> b/MdeModulePkg/Universal/PlatformDriOverrideDxe/PlatDriOverrideLib.c
> @@ -776,7 +776,7 @@ InitOverridesMapping (
> // Check buffer overflow
>
> //
>
> if ((DriverImageInfo->DriverImagePath == NULL) || (VariableIndex
> < (UINT8 *) DriverDevicePath) ||
>
> - (VariableIndex < (UINT8 *) VariableBuffer + BufferSize)) {
>
> + (VariableIndex > (UINT8 *) VariableBuffer + BufferSize)) {
>
> Corrupted = TRUE;
>
> break;
>
> }
>
> --
> 2.23.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#75092): https://edk2.groups.io/g/devel/message/75092
Mute This Topic: https://groups.io/mt/82791174/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
