Reviewed-by: Ray Ni <ray...@intel.com> Since it's a pure a build failure fix, I will merge it now.
> -----Original Message----- > From: mikub...@linux.microsoft.com <mikub...@linux.microsoft.com> > Sent: Wednesday, May 19, 2021 12:16 PM > To: devel@edk2.groups.io > Cc: Ni, Ray <ray...@intel.com>; Chaganty, Rangasai V > <rangasai.v.chaga...@intel.com>; Chuang, SofiaX <sofiax.chu...@intel.com> > Subject: [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg: Cast UINT32 to > UINT8 conversion in ReportCpuHobLib > > From: Michael Kubacki <michael.kuba...@microsoft.com> > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3404 > > Commit d3c10d3 introduced a build error in ReportCpuHobLib.c: > > IntelSiliconPkg\Library\ReportCpuHobLib\ReportCpuHobLib.c(30): > error C2220: warning treated as error - no 'object' file generated > IntelSiliconPkg\Library\ReportCpuHobLib\ReportCpuHobLib.c(30): > warning C4244: '=': conversion from 'UINT32' to 'UINT8', > possible loss of data > > This commit explicitly cast the assignment to fix the build error. > > Cc: Ray Ni <ray...@intel.com> > Cc: Rangasai V Chaganty <rangasai.v.chaga...@intel.com> > Cc: SofiaX Chuang <sofiax.chu...@intel.com> > Signed-off-by: Michael Kubacki <michael.kuba...@microsoft.com> > --- > Silicon/Intel/IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.c | > 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git > a/Silicon/Intel/IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.c > b/Silicon/Intel/IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.c > index 3f67b477d25a..56d63a35edcb 100644 > --- > a/Silicon/Intel/IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.c > +++ > b/Silicon/Intel/IntelSiliconPkg/Library/ReportCpuHobLib/ReportCpuHobLib.c > @@ -27,7 +27,7 @@ ReportCpuHob ( > AsmCpuid (CPUID_VIR_PHY_ADDRESS_SIZE, &AddressSizeEax.Uint32, > NULL, NULL, NULL); > if (AddressSizeEax.Uint32 >= CPUID_VIR_PHY_ADDRESS_SIZE) { > AsmCpuid (CPUID_VIR_PHY_ADDRESS_SIZE, &AddressSizeEax.Uint32, > NULL, NULL, NULL); > - PhysicalAddressBits = AddressSizeEax.Bits.PhysicalAddressBits; > + PhysicalAddressBits = (UINT8)AddressSizeEax.Bits.PhysicalAddressBits; > } else { > PhysicalAddressBits = 36; > } > -- > 2.28.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75409): https://edk2.groups.io/g/devel/message/75409 Mute This Topic: https://groups.io/mt/82929415/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-