On 5/26/21 10:14 PM, Laszlo Ersek wrote: > The OvmfXen platform specifies the dynamic access method for > "PcdPciDisableBusEnumeration" needlessly. > > After the DSC file sets the PCD to TRUE by default, the InitializeXen() > function in XenPlatformPei superfluously sets the PCD to TRUE again. There > are no other writes to the PCD in the platform. > > Make the PCD Fixed-At-Build, and remove the access (in fact, the whole > InitializeXen() function) from XenPlatformPei. > > Cc: Anthony Perard <anthony.per...@citrix.com> > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Julien Grall <jul...@xen.org> > Cc: Philippe Mathieu-Daudé <phi...@redhat.com> > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek <ler...@redhat.com> > --- > OvmfPkg/OvmfXen.dsc | 2 +- > OvmfPkg/XenPlatformPei/XenPlatformPei.inf | 1 - > OvmfPkg/XenPlatformPei/Platform.h | 5 ----- > OvmfPkg/XenPlatformPei/Platform.c | 1 - > OvmfPkg/XenPlatformPei/Xen.c | 20 -------------------- > 5 files changed, 1 insertion(+), 28 deletions(-)
Reviewed-by: Philippe Mathieu-Daude <phi...@redhat.com> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75783): https://edk2.groups.io/g/devel/message/75783 Mute This Topic: https://groups.io/mt/83110677/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
