Hi Gerd, On 05/28/21 16:16, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann <kra...@redhat.com> > --- > OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h | 1 + > OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c | 1 + > 2 files changed, 2 insertions(+)
Thanks for the patch! (1) Please write a non-empty commit message body. For example, "This error was found while compiling VirtioMmioDeviceLib for X64 with the GCC5 toolchain, where EFIAPI makes a difference." (I had to verify that the actual protocol member function type, VIRTIO_SET_QUEUE_ADDRESS [OvmfPkg/Include/Protocol/VirtioDevice.h], did spell out EFIAPI.) (2) The patch contains some CRLF issues; please consider running "BaseTools/Scripts/SetupGit.py" in your clone. Two things could be missing in particular: - the "8bit" (or even "base64") value for "sendemail.transferEncoding", - the "cr-at-eol" value for "core.whitespace". Thanks! Laszlo > > diff --git a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h > b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h > index 785876c75f82..ab53b90d51c9 100644 > --- a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h > +++ b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDevice.h > @@ -107,6 +107,7 @@ VirtioMmioSetQueueSel ( > ); > > > > EFI_STATUS > > +EFIAPI > > VirtioMmioSetQueueAddress ( > > IN VIRTIO_DEVICE_PROTOCOL *This, > > IN VRING *Ring, > > diff --git a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c > b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c > index 454f008827be..b0d75fb1dd24 100644 > --- a/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c > +++ b/OvmfPkg/Library/VirtioMmioDeviceLib/VirtioMmioDeviceFunctions.c > @@ -173,6 +173,7 @@ VirtioMmioSetQueueSel ( > } > > > > EFI_STATUS > > +EFIAPI > > VirtioMmioSetQueueAddress ( > > IN VIRTIO_DEVICE_PROTOCOL *This, > > IN VRING *Ring, > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#75898): https://edk2.groups.io/g/devel/message/75898 Mute This Topic: https://groups.io/mt/83149742/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
