Thank you, Michael. Acked-by: Jiewen Yao <jiewen....@intel.com>
> -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael > Kubacki > Sent: Wednesday, June 16, 2021 4:57 AM > To: devel@edk2.groups.io > Cc: Chiu, Chasel <chasel.c...@intel.com>; Desimone, Nathaniel L > <nathaniel.l.desim...@intel.com>; Liming Gao <gaolim...@byosoft.com.cn>; > Dong, Eric <eric.d...@intel.com>; Yao, Jiewen <jiewen....@intel.com>; > Jeremiah Cox <jere...@microsoft.com> > Subject: Re: [edk2-devel] [edk2-platforms][PATCH v2 0/4] MinPlatformPkg: Add > TPM platform hier disable support > > It's been a week and I haven't seen any feedback. Please review when > possible. > > Thanks, > Michael > > On 6/7/2021 12:05 PM, Michael Kubacki wrote: > > From: Michael Kubacki <michael.kuba...@microsoft.com> > > > > REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3411 > > > > This patch series adds support in TpmPlatformHierarchyLib to either > > randomize the platform auth (current behavior) or disable the > > platform auth (new behavior) based on a new PCD introduced to > > MinPlatformPkg: PcdRandomizePlatformHierarchy. > > > > Some platforms that would like to adopt MinPlatformPkg prefer to > > disable the platform hierarchy as opposed to the randomization > > approach. > > > > Minor changes are included to eliminate code duplication in impacted > > code. > > > > V2 changes: > > 1. Update code that randomizes the platform auth in Tcg2PlatformPei > > to use the TpmPlatformHierarchyLib interface for platform > > hierarchy configuration. > > 2. Remove pre-existing redundant code in Tcg2PlatformPei. > > 3. Add a PCD to allow the platform integrator to choose how to > > configure the TPM platform hierarchy. > > > > Cc: Chasel Chiu <chasel.c...@intel.com> > > Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> > > Cc: Liming Gao <gaolim...@byosoft.com.cn> > > Cc: Eric Dong <eric.d...@intel.com> > > Cc: Jiewen Yao <jiewen....@intel.com> > > Cc: Jeremiah Cox <jere...@microsoft.com> > > Signed-off-by: Michael Kubacki <michael.kuba...@microsoft.com> > > > > Michael Kubacki (4): > > MinPlatformPkg: Add TpmPlatformHierarchyLib to Components in DSC > > MinPlatformPkg/TpmPlatformHierarchyLib: Add PEI support > > MinPlatformPkg/Tcg2PlatformPei: Use TpmPlatformHierarchyLib > > MinPlatformPkg/TpmPlatformHierarchyLib: Add disable support > > > > > Platform/Intel/MinPlatformPkg/Tcg/Library/{TpmPlatformHierarchyLib/TpmPlat > formHierarchyLib.c => > PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.c} | 72 > +++++++++-- > > Platform/Intel/MinPlatformPkg/Tcg/Tcg2PlatformPei/Tcg2PlatformPei.c > | 130 +------------------- > > Platform/Intel/MinPlatformPkg/Include/Library/TpmPlatformHierarchyLib.h > | 4 +- > > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > | 1 + > > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dsc > | 4 +- > > > Platform/Intel/MinPlatformPkg/Tcg/Library/{TpmPlatformHierarchyLib/TpmPlat > formHierarchyLib.inf => > PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.inf} | 22 ++-- > > Platform/Intel/MinPlatformPkg/Tcg/Tcg2PlatformPei/Tcg2PlatformPei.inf > | 2 + > > 7 files changed, 85 insertions(+), 150 deletions(-) > > rename > Platform/Intel/MinPlatformPkg/Tcg/Library/{TpmPlatformHierarchyLib/TpmPlat > formHierarchyLib.c => > PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.c} (70%) > > rename > Platform/Intel/MinPlatformPkg/Tcg/Library/{TpmPlatformHierarchyLib/TpmPlat > formHierarchyLib.inf => > PeiDxeTpmPlatformHierarchyLib/PeiDxeTpmPlatformHierarchyLib.inf} (66%) > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#76565): https://edk2.groups.io/g/devel/message/76565 Mute This Topic: https://groups.io/mt/83373862/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
