Reviewed-by: Jiewen Yao <jiewen....@intel.com> > -----Original Message----- > From: Philippe Mathieu-Daudé <phi...@redhat.com> > Sent: Wednesday, July 21, 2021 4:21 PM > To: devel@edk2.groups.io; Yao, Jiewen <jiewen....@intel.com> > Cc: Laszlo Ersek <ler...@redhat.com>; Ard Biesheuvel > <ardb+tianoc...@kernel.org>; Justen, Jordan L <jordan.l.jus...@intel.com>; > Brijesh Singh <brijesh.si...@amd.com>; Erdem Aktas > <erdemak...@google.com>; James Bottomley <j...@linux.ibm.com>; Xu, Min > M <min.m...@intel.com>; Tom Lendacky <thomas.lenda...@amd.com> > Subject: Re: [PATCH v3] OvmfPkg: Remove unused print service driver (PrintDxe) > > Ping? > > On 7/7/21 8:02 PM, Philippe Mathieu-Daudé wrote: > > From: Philippe Mathieu-Daude <phi...@redhat.com> > > > > PrintDxe produces gEfiPrint2ProtocolGuid and gEfiPrint2SProtocolGuid, > > and those are consumed by the following PrintLib instance: > > > > > MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protocol.inf > > > > However, none of the OVMF DSC files contain such a PrintLib class > > resolution, so none of the OVMF platforms need PrintDxe. > > > > Cc: Laszlo Ersek <ler...@redhat.com> > > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> > > Cc: Jordan Justen <jordan.l.jus...@intel.com> > > Cc: Brijesh Singh <brijesh.si...@amd.com> > > Cc: Erdem Aktas <erdemak...@google.com> > > Cc: James Bottomley <j...@linux.ibm.com> > > Cc: Jiewen Yao <jiewen....@intel.com> > > Cc: Min Xu <min.m...@intel.com> > > Cc: Tom Lendacky <thomas.lenda...@amd.com> > > Suggested-by: Laszlo Ersek <ler...@redhat.com> > > Signed-off-by: Philippe Mathieu-Daude <phi...@redhat.com> > > --- > > OvmfPkg/AmdSev/AmdSevX64.dsc | 1 - > > OvmfPkg/Bhyve/BhyveX64.dsc | 1 - > > OvmfPkg/OvmfPkgIa32.dsc | 1 - > > OvmfPkg/OvmfPkgIa32X64.dsc | 1 - > > OvmfPkg/OvmfPkgX64.dsc | 1 - > > OvmfPkg/OvmfXen.dsc | 1 - > > OvmfPkg/AmdSev/AmdSevX64.fdf | 1 - > > OvmfPkg/Bhyve/BhyveX64.fdf | 1 - > > OvmfPkg/OvmfPkgIa32.fdf | 1 - > > OvmfPkg/OvmfPkgIa32X64.fdf | 1 - > > OvmfPkg/OvmfPkgX64.fdf | 1 - > > OvmfPkg/OvmfXen.fdf | 1 - > > 12 files changed, 12 deletions(-) > > > > diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc > b/OvmfPkg/AmdSev/AmdSevX64.dsc > > index 1d487befae08..d1974b4a6873 100644 > > --- a/OvmfPkg/AmdSev/AmdSevX64.dsc > > +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc > > @@ -722,7 +722,6 @@ [Components] > > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > > } > > - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > > diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc > > index 006831449518..c08fa9bdbf5b 100644 > > --- a/OvmfPkg/Bhyve/BhyveX64.dsc > > +++ b/OvmfPkg/Bhyve/BhyveX64.dsc > > @@ -673,7 +673,6 @@ [Components] > > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > > } > > - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > > index f53efeae7986..dff4b97b37c0 100644 > > --- a/OvmfPkg/OvmfPkgIa32.dsc > > +++ b/OvmfPkg/OvmfPkgIa32.dsc > > @@ -816,7 +816,6 @@ [Components] > > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > > } > > - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > > index b3662e17f256..f3df655c990e 100644 > > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > > @@ -830,7 +830,6 @@ [Components.X64] > > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > > } > > - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > > index 0a237a905866..dc9a2720f9b2 100644 > > --- a/OvmfPkg/OvmfPkgX64.dsc > > +++ b/OvmfPkg/OvmfPkgX64.dsc > > @@ -828,7 +828,6 @@ [Components] > > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > > } > > - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > > diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc > > index 3c1ca6bfd493..aee91a61e7c3 100644 > > --- a/OvmfPkg/OvmfXen.dsc > > +++ b/OvmfPkg/OvmfXen.dsc > > @@ -610,7 +610,6 @@ [Components] > > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > > } > > - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > > diff --git a/OvmfPkg/AmdSev/AmdSevX64.fdf > b/OvmfPkg/AmdSev/AmdSevX64.fdf > > index 9977b0f00a18..42f120d016e1 100644 > > --- a/OvmfPkg/AmdSev/AmdSevX64.fdf > > +++ b/OvmfPkg/AmdSev/AmdSevX64.fdf > > @@ -234,7 +234,6 @@ [FV.DXEFV] > > INF MdeModulePkg/Application/UiApp/UiApp.inf > > INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf > > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > > -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > > INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > > diff --git a/OvmfPkg/Bhyve/BhyveX64.fdf b/OvmfPkg/Bhyve/BhyveX64.fdf > > index b3b4d44cef34..e8227f865f75 100644 > > --- a/OvmfPkg/Bhyve/BhyveX64.fdf > > +++ b/OvmfPkg/Bhyve/BhyveX64.fdf > > @@ -233,7 +233,6 @@ [FV.DXEFV] > > INF MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > > INF MdeModulePkg/Application/UiApp/UiApp.inf > > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > > -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > > INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > > diff --git a/OvmfPkg/OvmfPkgIa32.fdf b/OvmfPkg/OvmfPkgIa32.fdf > > index 04b41445ca34..031eb4225c53 100644 > > --- a/OvmfPkg/OvmfPkgIa32.fdf > > +++ b/OvmfPkg/OvmfPkgIa32.fdf > > @@ -254,7 +254,6 @@ [FV.DXEFV] > > INF MdeModulePkg/Application/UiApp/UiApp.inf > > INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf > > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > > -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > > INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > > diff --git a/OvmfPkg/OvmfPkgIa32X64.fdf b/OvmfPkg/OvmfPkgIa32X64.fdf > > index 02fd8f0c413e..7194f08e6024 100644 > > --- a/OvmfPkg/OvmfPkgIa32X64.fdf > > +++ b/OvmfPkg/OvmfPkgIa32X64.fdf > > @@ -255,7 +255,6 @@ [FV.DXEFV] > > INF MdeModulePkg/Application/UiApp/UiApp.inf > > INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf > > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > > -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > > INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > > diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf > > index 5fa8c0895808..b304e3149d4f 100644 > > --- a/OvmfPkg/OvmfPkgX64.fdf > > +++ b/OvmfPkg/OvmfPkgX64.fdf > > @@ -267,7 +267,6 @@ [FV.DXEFV] > > INF MdeModulePkg/Application/UiApp/UiApp.inf > > INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf > > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > > -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > > INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > > diff --git a/OvmfPkg/OvmfXen.fdf b/OvmfPkg/OvmfXen.fdf > > index aeb9336fd5b7..d109341d2890 100644 > > --- a/OvmfPkg/OvmfXen.fdf > > +++ b/OvmfPkg/OvmfXen.fdf > > @@ -325,7 +325,6 @@ [FV.DXEFV] > > INF MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > > INF MdeModulePkg/Application/UiApp/UiApp.inf > > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > > -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > > INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > >
-=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#78022): https://edk2.groups.io/g/devel/message/78022 Mute This Topic: https://groups.io/mt/84050542/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
