On Mon, 6 Sept 2021 at 13:44, Yao, Jiewen <jiewen....@intel.com> wrote: > > I think it makes sense to put Fdt to OvmfPkg. I suggest an Fdt folder and put > all things there. > > > > I also think we define Fdt feature in > https://github.com/tianocore/edk2/blob/master/Maintainers.txt to add reviewer > there to help review the code. > >
Agreed. > > > > > > From: Chang, Abner (HPS SW/FW Technologist) <abner.ch...@hpe.com> > Sent: Monday, September 6, 2021 7:09 PM > To: Yao, Jiewen <jiewen....@intel.com>; devel@edk2.groups.io; gaoliming > <gaolim...@byosoft.com.cn> > Cc: 'Ard Biesheuvel' <ard.biesheu...@arm.com>; Kinney, Michael D > <michael.d.kin...@intel.com>; 'Leif Lindholm' <l...@nuviainc.com>; Ni, Ray > <ray...@intel.com>; Schaefer, Daniel <daniel.schae...@hpe.com>; 'Sunil V L' > <suni...@ventanamicro.com>; 'Ard Biesheuvel' <ardb+tianoc...@kernel.org>; > 'Gerd Hoffmann' <kra...@redhat.com> > Subject: RE: [edk2-devel] [RFC] RISC-V QEMU virtual package > > > > Hi Jiewen, > > We currently only use below modules from ArmVirtPkg, > > ArmVirtPkg/Library > > FdtPciPcdProducerLib > FdtPciHostBridgeLib > > ArmVirtPkg/ > > VirtioFdtDxe > FdtClientDxe > HighMemDxe > > Above modules are related to the extraction of the platform configuration > from FDT. We also use ArmPkg/DriverArmPciCpuIoDxe, we can have RISC-V > instance of CpuIoDxe but still leverage PCD produced by FdtPciPcdProducerLib. > > Another library is QemuFwCfgLib from ArmVirtPkg/Library, I think we can have > RISC-V own instance because there is a one instance under OvmfPkg already. > > > > Thanks > > Abner > > > > > > From: Yao, Jiewen [mailto:jiewen....@intel.com] > Sent: Monday, September 6, 2021 2:16 PM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > <abner.ch...@hpe.com>; gaoliming <gaolim...@byosoft.com.cn> > Cc: 'Ard Biesheuvel' <ard.biesheu...@arm.com>; Kinney, Michael D > <michael.d.kin...@intel.com>; 'Leif Lindholm' <l...@nuviainc.com>; Ni, Ray > <ray...@intel.com>; Schaefer, Daniel <daniel.schae...@hpe.com>; 'Sunil V L' > <suni...@ventanamicro.com>; 'Ard Biesheuvel' <ardb+tianoc...@kernel.org>; > 'Gerd Hoffmann' <kra...@redhat.com> > Subject: RE: [edk2-devel] [RFC] RISC-V QEMU virtual package > > > > Do you have a list of which module you want to move to Ovmf? > > > > I think we can discuss case by case. > > > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Abner Chang > Sent: Monday, September 6, 2021 12:16 PM > To: gaoliming <gaolim...@byosoft.com.cn>; devel@edk2.groups.io > Cc: 'Ard Biesheuvel' <ard.biesheu...@arm.com>; Kinney, Michael D > <michael.d.kin...@intel.com>; 'Leif Lindholm' <l...@nuviainc.com>; Ni, Ray > <ray...@intel.com>; Schaefer, Daniel <daniel.schae...@hpe.com>; 'Sunil V L' > <suni...@ventanamicro.com>; Yao, Jiewen <jiewen....@intel.com>; 'Ard > Biesheuvel' <ardb+tianoc...@kernel.org>; 'Gerd Hoffmann' <kra...@redhat.com> > Subject: Re: [edk2-devel] [RFC] RISC-V QEMU virtual package > > > > Thanks Liming. To have those modules under OvmfPkg also makes sense to me. > See how others think of this. > > > > Abner > > > > From: gaoliming [mailto:gaolim...@byosoft.com.cn] > Sent: Monday, September 6, 2021 9:07 AM > To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) > <abner.ch...@hpe.com> > Cc: 'Ard Biesheuvel' <ard.biesheu...@arm.com>; 'Michael D Kinney' > <michael.d.kin...@intel.com>; 'Leif Lindholm' <l...@nuviainc.com>; > ray...@intel.com; Schaefer, Daniel <daniel.schae...@hpe.com>; 'Sunil V L' > <suni...@ventanamicro.com>; jiewen....@intel.com; 'Ard Biesheuvel' > <ardb+tianoc...@kernel.org>; 'Gerd Hoffmann' <kra...@redhat.com> > Subject: 回复: [edk2-devel] [RFC] RISC-V QEMU virtual package > > > > Abner: > > If these modules are shared by ARM and RISC-V, they should not be ARM > specific modules. I prefer to move them into OvmfPkg. Now, ArmVirtPkg also > includes the modules from OvmfPkg. > > > > I also include OVMF package maintainers for this discussion. > > > > Thanks > > Liming > > 发件人: devel@edk2.groups.io <devel@edk2.groups.io> 代表 Abner Chang > 发送时间: 2021年9月5日 11:15 > 收件人: devel@edk2.groups.io > 抄送: Ard Biesheuvel <ard.biesheu...@arm.com>; Michael D Kinney > <michael.d.kin...@intel.com>; Leif Lindholm <l...@nuviainc.com>; > ray...@intel.com; Liming Gao <gaolim...@byosoft.com.cn>; Schaefer, Daniel > <daniel.schae...@hpe.com>; Sunil V L <suni...@ventanamicro.com> > 主题: [edk2-devel] [RFC] RISC-V QEMU virtual package > > > > Hi all, > > We currently have RISC-V edk2 OVMF package that can boot to Linux kernel on > QEMU RISC-V virt platform. > > First at all, we would like to create a folder RiscvVirtPkg under edk2 repo > and integrated in the Platform CI build. > > > > Second, RISC-V edk2 OVMF package leverages some edk2 libraries and drivers > from ArmVirtPkg, such as FDT related modules for PCI bus, host bridge and > etc. We would like to move those generic virtual drivers to > > a common folder for ARM and RISC-V (I don’t think this way is necessary > though). Or can we move those to just under OvmfPkg because OvmfPkg also > provides some common drivers for the processor architectures. > > Thoughts? > > > > Thanks > > Abner > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#80264): https://edk2.groups.io/g/devel/message/80264 Mute This Topic: https://groups.io/mt/85405739/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
