On Wed, Sep 22, 2021 at 14:20:31 +0200, Ard Biesheuvel wrote: > On Wed, 22 Sept 2021 at 14:14, Leif Lindholm <l...@nuviainc.com> wrote: > > > > On Wed, Sep 22, 2021 at 13:24:07 +0200, Ard Biesheuvel wrote: > > > On Tue, 21 Sept 2021 at 13:02, Marcin Wojtas <m...@semihalf.com> wrote: > > > > > > > > Hi, > > > > > > > > This short patchset adds README files for the platforms > > > > based on Marvell SoC's, which have already been > > > > SystemReady ES certified. It also bumps the firmware > > > > revision after the PCI / IcuLib rework and addition of > > > > the CN913x CEx7 Evaluation Board support. > > > > > > > > The patches are available on a public branch: > > > > https://github.com/semihalf-wojtas-marcin/edk2-platforms/commits/marvell-howtos-upstream-r20210921 > > > > > > > > > > Thanks > > > > > > Pushed as 64394fd2b48f..d1d4dd2c39e7 > > > > Ugh, wish I'd taken the time to respond yesterday. > > > > This is more proliferation of "include all very specific build > > steps for a very specific target and build environment" documentation. > > > > I don't see this as an improvement. > > > > Platform docs should document what one needs to know specific to the > > platform. If a vendor wishes to provide full recipes, they should host > > that on a wiki somewhere. > > > > Fair point. > > Marcin, when you find the time, could you please do a pass over these > files with Leif's critique in mind?
Some suggestions/requests: The top-level Readme.md should contain all relevant build system and cross compilation information, so please refer to that instead of duplicating information. If it is missing some generically useful information, please add it. (That file, for example, points out the appropriate location to get arm cross-toolchains from if your distro doesn't provide them, and Linaro stopped working on GCC years ago.) Please *do* document the repositories required to build (and hence need to specify in PACKAGES_PATH). The example build command line for CN913x CEx7 requires edk2-non-osi. Please don't document the inclusion of the Shell TFTP command by default. Mention it as an option if you must. Document the builds in chronological order, don't interleave TF-A and EDK2 instructions. Ideally, cut TF-A instructions down to a bare minimum (e.g. "pass the generated EDK2 image to the TF-A build with `$ export BL33=...`) and link to aforementioned wiki page for the full recipe. Best Regards, Leif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#80964): https://edk2.groups.io/g/devel/message/80964 Mute This Topic: https://groups.io/mt/85762836/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
