Star, It might be better to split the patch to two patches. one is to change MdePkg adding the definitions. The other is to change ShellPkg consuming the definitions.
> -----Original Message----- > From: Zeng, Star <[email protected]> > Sent: Tuesday, September 28, 2021 10:11 AM > To: [email protected]; Zeng, Star <[email protected]> > Cc: [email protected]; Kinney, Michael D <[email protected]>; > Liu, Zhiguang <[email protected]>; Ni, > Ray <[email protected]>; Gao, Zhichao <[email protected]> > Subject: RE: [edk2-devel] [PATCH] MdePkg,ShellPkg: Add > ProcessorUpgradeSocketLGA4677 from SMBIOS 3.5.0 > > + Maintainers and Reviewers > > -----Original Message----- > From: [email protected] <[email protected]> On Behalf Of Zeng, Star > Sent: 2021年9月28日 10:04 > To: [email protected] > Cc: Zeng, Star <[email protected]> > Subject: [edk2-devel] [PATCH] MdePkg,ShellPkg: Add > ProcessorUpgradeSocketLGA4677 from SMBIOS 3.5.0 > > This patch adds ProcessorUpgradeSocketLGA4677 definition into Smbios.h from > SMBIOS 3.5.0 and entry into QueryTable.c. > It also adds ProcessorUpgradeSocketLGA4189 and ProcessorUpgradeSocketLGA1200 > into from SMBIOS 3.4.0 and entries into > QueryTable.c. > > Signed-off-by: Star Zeng <[email protected]> > --- > MdePkg/Include/IndustryStandard/SmBios.h | 7 +++++-- > .../SmbiosView/QueryTable.c | 14 +++++++++++++- > 2 files changed, 18 insertions(+), 3 deletions(-) > > diff --git a/MdePkg/Include/IndustryStandard/SmBios.h > b/MdePkg/Include/IndustryStandard/SmBios.h > index 6918f58cce44..2c2b32b8d462 100644 > --- a/MdePkg/Include/IndustryStandard/SmBios.h > +++ b/MdePkg/Include/IndustryStandard/SmBios.h > @@ -1,7 +1,7 @@ > /** @file Industry Standard Definitions of SMBIOS Table Specification > v3.3.0. -Copyright (c) 2006 - 2019, Intel Corporation. All > rights reserved.<BR>+Copyright (c) 2006 - 2021, Intel Corporation. All rights > reserved.<BR> (C) Copyright 2015-2017 Hewlett > Packard Enterprise Development LP<BR> (C) Copyright 2015 - 2019 Hewlett > Packard Enterprise Development LP<BR> SPDX- > License-Identifier: BSD-2-Clause-Patent@@ -810,7 +810,10 @@ typedef enum { > ProcessorUpgradeSocketLGA2066 = 0x39, ProcessorUpgradeSocketBGA1392 > = 0x3A, ProcessorUpgradeSocketBGA1510 > = 0x3B,- ProcessorUpgradeSocketBGA1528 = 0x3C+ > ProcessorUpgradeSocketBGA1528 = 0x3C,+ > ProcessorUpgradeSocketLGA4189 = 0x3D,+ ProcessorUpgradeSocketLGA1200 = > 0x3E,+ ProcessorUpgradeSocketLGA4677 = > 0x3F } PROCESSOR_UPGRADE; ///diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c > index 7fc9d38a3b03..c312a7f8f227 100644 > --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c > +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > +++ c > @@ -2,7 +2,7 @@ > Build a table, each item is (Key, Info) pair. And give a interface of > query a string out of a table. - Copyright (c) 2005 - 2019, > Intel Corporation. All rights reserved.<BR>+ Copyright (c) 2005 - 2021, > Intel Corporation. All rights reserved.<BR> (C) Copyright > 2016-2019 Hewlett Packard Enterprise Development LP<BR> > SPDX-License-Identifier: BSD-2-Clause-Patent @@ -589,6 +589,18 > @@ TABLE_ITEM ProcessorUpgradeTable[] = { > { 0x3C, L"Socket BGA1528"+ },+ {+ 0x3D,+ L"Socket > LGA4189"+ },+ {+ 0x3E,+ L"Socket LGA1200"+ },+ {+ 0x3F,+ > L"Socket LGA4677" } }; -- > 2.27.0.windows.1 > > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#81189): https://edk2.groups.io/g/devel/message/81189 > Mute This Topic: https://groups.io/mt/85916590/1779220 > Group Owner: [email protected] > Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] > -=-=-=-=-=-= > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#81193): https://edk2.groups.io/g/devel/message/81193 Mute This Topic: https://groups.io/mt/85916590/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
