On 10/4/21 18:45, Sunil V L wrote: > On Mon, Oct 04, 2021 at 01:23:57AM +0800, Daniel Schaefer wrote: >> Cc: Abner Chang <abner.ch...@hpe.com> >> Cc: Sunil V L <suni...@ventanamicro.com> >> Cc: Leif Lindholm <l...@nuviainc.com> >> >> Signed-off-by: Daniel Schaefer <daniel.schae...@hpe.com> >> --- >> Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | 7 >> +++++++ >> Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.fdf | 1 + >> Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 7 >> +++++++ >> Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.fdf | 1 + >> 4 files changed, 16 insertions(+) >> >> diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc >> b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc >> index cdc1b9ee8f..23f50ab2c4 100644 >> --- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc >> +++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc >> @@ -513,6 +513,13 @@ >> FatPkg/EnhancedFatDxe/Fat.inf >> MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf >> >> + OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf >> { >> + <PcdsFixedAtBuild> >> + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE >> + <LibraryClasses> >> + ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf > Do we need to add UefiShellLib.inf here? Same question for other changes > too.
You're right. We don't, if we add it to the regular libraries. Neither do we need it for ShellPkg/Application/Shell/Shell.inf I'll remove it. >> + } >> + >> ShellPkg/Application/Shell/Shell.inf { >> <LibraryClasses> >> >> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf >> diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.fdf >> b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.fdf >> index f262e4fe17..5f3ac8e0b7 100644 >> --- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.fdf >> +++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.fdf >> @@ -187,6 +187,7 @@ INF MdeModulePkg/Universal/SerialDxe/SerialDxe.inf >> >> INF MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf >> >> +INF >> OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf >> INF ShellPkg/Application/Shell/Shell.inf >> >> # >> diff --git >> a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc >> b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc >> index be70ef5294..850d60afa2 100644 >> --- a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc >> +++ b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc >> @@ -512,6 +512,13 @@ >> FatPkg/EnhancedFatDxe/Fat.inf >> MdeModulePkg/Universal/Disk/UdfDxe/UdfDxe.inf >> >> + OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf >> { >> + <PcdsFixedAtBuild> >> + gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE >> + <LibraryClasses> >> + ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf >> + } >> + >> ShellPkg/Application/Shell/Shell.inf { >> <LibraryClasses> >> >> ShellCommandLib|ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.inf >> diff --git >> a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.fdf >> b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.fdf >> index c0ce09fcee..a1a4b342e3 100644 >> --- a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.fdf >> +++ b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.fdf >> @@ -187,6 +187,7 @@ INF MdeModulePkg/Universal/SerialDxe/SerialDxe.inf >> >> INF MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf >> >> +INF >> OvmfPkg/LinuxInitrdDynamicShellCommand/LinuxInitrdDynamicShellCommand.inf >> INF ShellPkg/Application/Shell/Shell.inf >> >> # >> -- >> 2.33.0 >> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#81435): https://edk2.groups.io/g/devel/message/81435 Mute This Topic: https://groups.io/mt/86046983/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-