Hello, Thanks for all your valuable feedbacks, I have sent V4 to incorporate all of them, please help to review.
Thanks, Chasel > -----Original Message----- > From: Chiu, Chasel <chasel.c...@intel.com> > Sent: Friday, October 8, 2021 2:43 PM > To: devel@edk2.groups.io > Cc: Chiu, Chasel <chasel.c...@intel.com>; Oram, Isaac W > <isaac.w.o...@intel.com>; Desimone, Nathaniel L > <nathaniel.l.desim...@intel.com>; Luo, Heng <heng....@intel.com>; Jeremy > Soller <jer...@system76.com>; Benjamin Doron > <benjamin.doro...@gmail.com>; Chaganty, Rangasai V > <rangasai.v.chaga...@intel.com>; Kethi Reddy, Deepika > <deepika.kethi.re...@intel.com>; Esakkithevar, Kathappan > <kathappan.esakkithe...@intel.com>; Liming Gao > <gaolim...@byosoft.com.cn>; Dong, Eric <eric.d...@intel.com> > Subject: [edk2-platforms: PATCH v3 0/9] MinPlatformPkg: Support FSP 2.3 > FSP_NON_VOLATILE_STORAGE_HOB2. > > V3: > Fix another GCC build failure. > > V2: > Fix GCC build failures. > > V1: > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3678 > > Implementation should search FSP_NON_VOLATILE_STORAGE_HOB2 firstly and > only search FSP_NON_VOLATILE_STORAGE_HOB when former one is not found. > > Also added PeiGetLargeVariable () to support the scenarios where the variable > data size is bigger than a single variable size limit. > > Cc: Isaac Oram <isaac.w.o...@intel.com> > Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> > Cc: Heng Luo <heng....@intel.com> > Cc: Jeremy Soller <jer...@system76.com> > Cc: Benjamin Doron <benjamin.doro...@gmail.com> > Cc: Rangasai V Chaganty <rangasai.v.chaga...@intel.com> > Cc: Deepika Kethi Reddy <deepika.kethi.re...@intel.com> > Cc: Kathappan Esakkithevar <kathappan.esakkithe...@intel.com> > Cc: Liming Gao <gaolim...@byosoft.com.cn> > Cc: Eric Dong <eric.d...@intel.com> > Signed-off-by: Chasel Chiu <chasel.c...@intel.com> > > Chasel Chiu (9): > MinPlatformPkg: Support FSP 2.3 FSP_NON_VOLATILE_STORAGE_HOB2. > CometlakeOpenBoardPkg: Use same variable name for FspNvsHob. > KabylakeOpenBoardPkg/AspireVn7Dash572G:Use same variable name for > FspNvsHob > KabylakeOpenBoardPkg/GalagoPro3: Use same variable name for FspNvsHob. > KabylakeOpenBoardPkg/KabylakeRvp3: Use same variable name for > FspNvsHob. > TigerlakeOpenBoardPkg: Use same variable name for FspNvsHob. > WhiskeylakeOpenBoardPkg: Use same variable name for FspNvsHob. > WhitleyOpenBoardPkg: Support FSP 2.3 FSP_NON_VOLATILE_STORAGE_HOB2. > WhitleySiliconPkg: Use same variable name for FspNvsHob. > > > Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiSiliconPolicyU > pdateLibFsp/PeiFspMiscUpdUpdateLib.c | 63 > ++++++++++++++----- > -------------------------------------------- > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Librar > y/PeiSiliconPolicyUpdateLibFsp/PeiFspMiscUpdUpdateLib.c | 24 > ++++++++++-------------- > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/PeiSi > liconPolicyUpdateLib/PeiSiliconPolicyUpdateLib.c | 23 > +++++++++---------- > ---- > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/FspWrapper/Library/PeiSilic > onPolicyUpdateLibFsp/PeiFspMiscUpdUpdateLib.c | 24 > ++++++++++----- > --------- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/FspWrapper/Library/PeiSi > liconPolicyUpdateLibFsp/PeiFspMiscUpdUpdateLib.c | 25 > ++++++++++---- > ----------- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Policy/Library/PeiSiliconP > olicyUpdateLib/PeiSiliconPolicyUpdateLib.c | 23 > +++++++++-------------- > > Platform/Intel/MinPlatformPkg/FspWrapper/SaveMemoryConfig/SaveMemoryC > onfig.c | 39 > ++++++++++++++++++++++++++++-- > --------- > Platform/Intel/MinPlatformPkg/Library/PeiLib/PeiLib.c > | 69 > +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ > +++- > > Platform/Intel/MinPlatformPkg/Library/PeiVariableReadLib/PeiVariableReadLib. > c | 4 ++-- > > Platform/Intel/TigerlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolicyInitLib/ > PeiFspPolicyInitLib.c | 21 > ++++++++++++++++++--- > > Platform/Intel/WhiskeylakeOpenBoardPkg/FspWrapper/Library/PeiSiliconPolicy > UpdateLibFsp/PeiFspMiscUpdUpdateLib.c | 63 > ++++++++++++------- > -------------------------------------------- > > Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/FspWrapper/Library/PeiSi > liconPolicyUpdateLibFsp/PeiFspMiscUpdUpdateLib.c | 63 > ++++++++++++--------------------------------------------------- > > Platform/Intel/WhitleyOpenBoardPkg/Platform/Dxe/S3NvramSave/S3NvramSav > e.c | 29 > +++++++++++++++++++++++------ > > Silicon/Intel/WhitleySiliconPkg/Library/FspWrapperPlatformLib/FspWrapperPlat > formLib.c | 35 > +++++++++-------------------------- > Platform/Intel/CometlakeOpenBoardPkg/CometlakeURvp/OpenBoardPkg.dsc > | 3 +++ > > Platform/Intel/CometlakeOpenBoardPkg/FspWrapper/Library/PeiSiliconPolicyU > pdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf | 5 ++--- > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/FspWrapper/Librar > y/PeiSiliconPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf | 7 ++++--- > > Platform/Intel/KabylakeOpenBoardPkg/AspireVn7Dash572G/Policy/Library/PeiSi > liconPolicyUpdateLib/PeiSiliconPolicyUpdateLib.inf | 2 +- > > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/FspWrapper/Library/PeiSilic > onPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf | 5 ++--- > Platform/Intel/KabylakeOpenBoardPkg/GalagoPro3/OpenBoardPkg.dsc > | 3 +++ > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/FspWrapper/Library/PeiSi > liconPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf | 5 ++--- > > Platform/Intel/KabylakeOpenBoardPkg/KabylakeRvp3/Policy/Library/PeiSiliconP > olicyUpdateLib/PeiSiliconPolicyUpdateLib.inf | 2 +- > > Platform/Intel/MinPlatformPkg/FspWrapper/SaveMemoryConfig/SaveMemoryC > onfig.inf | 5 ++++- > Platform/Intel/MinPlatformPkg/Include/Library/PeiLib.h > | 33 ++++++++++++++++++++++++++++++++- > Platform/Intel/MinPlatformPkg/Library/PeiLib/PeiLib.inf > | 4 +++- > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > | 1 + > > Platform/Intel/TigerlakeOpenBoardPkg/FspWrapper/Library/PeiFspPolicyInitLib/ > PeiFspPolicyInitLib.inf | 1 + > Platform/Intel/TigerlakeOpenBoardPkg/TigerlakeURvp/OpenBoardPkg.dsc > | 3 +++ > > Platform/Intel/WhiskeylakeOpenBoardPkg/FspWrapper/Library/PeiSiliconPolicy > UpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf | 5 ++--- > > Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/FspWrapper/Library/PeiSi > liconPolicyUpdateLibFsp/PeiSiliconPolicyUpdateLibFsp.inf | 4 ++-- > > Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/Include/Fdf/FlashMapIncl > ude.fdf | 18 > +++++++++--------- > Platform/Intel/WhiskeylakeOpenBoardPkg/UpXtreme/OpenBoardPkg.dsc > | 3 +++ > > Platform/Intel/WhiskeylakeOpenBoardPkg/WhiskeylakeURvp/OpenBoardPkg.ds > c | 3 +++ > > Platform/Intel/WhitleyOpenBoardPkg/Platform/Dxe/S3NvramSave/S3NvramSav > e.inf | 4 +++- > Platform/Intel/WhitleyOpenBoardPkg/PlatformPkg.dsc > | 1 + > > Silicon/Intel/WhitleySiliconPkg/Library/FspWrapperPlatformLib/FspWrapperPlat > formLib.inf | 3 ++- > 36 files changed, 321 insertions(+), 304 deletions(-) > > -- > 2.28.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#81960): https://edk2.groups.io/g/devel/message/81960 Mute This Topic: https://groups.io/mt/86164704/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
