In the success case we should return EFI_SUCCESS rather than returning a potentially unitialized value of Status.
Cc: Sami Mujawar <sami.muja...@arm.com> Cc: Alexei Fedorov <alexei.fedo...@arm.com> Signed-off-by: Moritz Fischer <mori...@google.com> --- .../Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c index 0bdb6c24c5bb..e9e1a85ede63 100644 --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlResourceDataCodeGen.c @@ -91,7 +91,7 @@ LinkRdNode ( *NewRdNode = RdNode; } - return Status; + return EFI_SUCCESS; error_handler: Status1 = AmlDeleteTree ((AML_NODE_HEADER*)RdNode); -- 2.33.0.1079.g6e70778dc9-goog -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#82412): https://edk2.groups.io/g/devel/message/82412 Mute This Topic: https://groups.io/mt/86458612/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-