Hi Ray and Rahul, Any comment on this patch ? If you are okay with it then can I get Ack or R-b ?
-Brijesh On 10/22/21 11:13 PM, Brijesh Singh wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=3275 > > While initializing APs, the MpInitLib may need to know whether the > guest is running with active AMD SEV or Intel TDX memory encryption. > > Add a new ConfidentialComputingGuestAttr PCD that can be used to query > the memory encryption attribute. > > Cc: Michael Roth <michael.r...@amd.com> > Cc: Ray Ni <ray...@intel.com> > Cc: Rahul Kumar <rahul1.ku...@intel.com> > Cc: Eric Dong <eric.d...@intel.com> > Cc: James Bottomley <j...@linux.ibm.com> > Cc: Min Xu <min.m...@intel.com> > Cc: Jiewen Yao <jiewen....@intel.com> > Cc: Tom Lendacky <thomas.lenda...@amd.com> > Cc: Jordan Justen <jordan.l.jus...@intel.com> > Cc: Ard Biesheuvel <ardb+tianoc...@kernel.org> > Cc: Erdem Aktas <erdemak...@google.com> > Cc: Gerd Hoffmann <kra...@redhat.com> > Suggested-by: Jiewen Yao <jiewen....@intel.com> > Acked-by: Gerd Hoffmann <kra...@redhat.com> > Signed-off-by: Brijesh Singh <brijesh.si...@amd.com> > --- > MdePkg/MdePkg.dec | 4 +++ > .../Include/ConfidentialComputingGuestAttr.h | 25 +++++++++++++++++++ > 2 files changed, 29 insertions(+) > create mode 100644 MdePkg/Include/ConfidentialComputingGuestAttr.h > > diff --git a/MdePkg/MdePkg.dec b/MdePkg/MdePkg.dec > index 8b18415b107a..cd903c35d2ff 100644 > --- a/MdePkg/MdePkg.dec > +++ b/MdePkg/MdePkg.dec > @@ -2396,5 +2396,9 @@ [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, > PcdsDynamicEx] > # @Prompt FSB Clock. > gEfiMdePkgTokenSpaceGuid.PcdFSBClock|200000000|UINT32|0x0000000c > > + ## This dynamic PCD indicates the memory encryption attribute of the guest. > + # @Prompt Memory encryption attribute > + > gEfiMdePkgTokenSpaceGuid.PcdConfidentialComputingGuestAttr|0|UINT64|0x0000002e > + > [UserExtensions.TianoCore."ExtraFiles"] > MdePkgExtra.uni > diff --git a/MdePkg/Include/ConfidentialComputingGuestAttr.h > b/MdePkg/Include/ConfidentialComputingGuestAttr.h > new file mode 100644 > index 000000000000..495b0df0ac33 > --- /dev/null > +++ b/MdePkg/Include/ConfidentialComputingGuestAttr.h > @@ -0,0 +1,25 @@ > +/** @file > +Definitions for Confidential Computing Attribute > + > +Copyright (c) 2021 AMD Inc. All rights reserved.<BR> > +SPDX-License-Identifier: BSD-2-Clause-Patent > + > +**/ > + > +#ifndef CONFIDENTIAL_COMPUTING_GUEST_ATTR_H_ > +#define CONFIDENTIAL_COMPUTING_GUEST_ATTR_H_ > + > +typedef enum { > + /* The guest is running with memory encryption disabled. */ > + CCAttrNotEncrypted = 0, > + > + /* The guest is running with AMD SEV memory encryption enabled. */ > + CCAttrAmdSev = 0x100, > + CCAttrAmdSevEs = 0x101, > + CCAttrAmdSevSnp = 0x102, > + > + /* The guest is running with Intel TDX memory encryption enabled. */ > + CCAttrIntelTdx = 0x200, > +} CONFIDENTIAL_COMPUTING_GUEST_ATTR; > + > +#endif -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#82612): https://edk2.groups.io/g/devel/message/82612 Mute This Topic: https://groups.io/mt/86530733/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
