Hi Ray, Sai, Could you take a look on this patch?
Pasting below questions and answers from previous patch for a reference. What's the difference between SOC and CPU? SOC die differs from typical CPU die in Intel's chiplet design. What the purpose of "DieIndex"? We want to have an indication to which exactly die given protocol instance is referring to (in example in multi socket/multi PCH designs). Have you considered to use data fields such as "CONST CHAR8 * DieName, Stepping, Sku" instead of the methods? Yes, but there might be a configuration where chipset id is going to be changed during the boot. By using methods, we ensure that returned value is correct in every call. Can you add some details on how a producer of this interface would know the values to be assigned here? Does this contain any sort of encoding of generation and Die specific ID in a single UINT64? Yes, in order to have a generic field regardless of the die type and per-generation changes it will be packed into a single UINT64. Protocol will be installed by silicon code, and consumer will need to be aware of the encoding and decode it. Same applies for stepping id. Any reason the die specific GUIDs are not declared in the .dec file? I can't see any problems with that, they will be added in v2 changes. --------------------------------------------------------------------- Intel Technology Poland sp. z o.o. ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN. Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek przegladanie lub rozpowszechnianie jest zabronione. This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by others is strictly prohibited. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#82709): https://edk2.groups.io/g/devel/message/82709 Mute This Topic: https://groups.io/mt/86608843/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
