On Thu, Oct 28, 2021 at 02:07:58AM +0000, Yao, Jiewen wrote: > Besides VmgExitLib - > https://github.com/tianocore/edk2/blob/master/UefiCpuPkg/Include/Library/VmgExitLib.h > > We have another potential issue - MemEncryptSevLib - > https://github.com/tianocore/edk2/blob/master/OvmfPkg/Include/Library/MemEncryptSevLib.h > We might need rename it to MemEncryptionTeeLib. > > I think we need setup direction on how to hand those cases in a consistent > way. > > Option 1: Keep using current name: SEV and TDX as two class name. Add two > instances. > > Option 2: Define a new architecture neutral class name such as TEE. Add one > instance to cover both SEV and TDX.
(2) looks better to me (for libraries, drivers is a different story). Would also have the advantage that we can probably move (some of) the dispatcher code (if sev call this, if tdx call that, else do nothing) into the library too. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#82800): https://edk2.groups.io/g/devel/message/82800 Mute This Topic: https://groups.io/mt/86085742/21656 Mute #ve:https://edk2.groups.io/g/devel/mutehashtag/ve Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
