Hi, > STATIC UINT16 mAcpiPmBaseAddress; > +STATIC UINT16 mAcpiHwReducedSleepCtl; > > EFI_STATUS > EFIAPI > @@ -26,6 +27,7 @@ DxeResetInit ( > { > UINT16 HostBridgeDevId; > > + mAcpiPmBaseAddress = 0;
Hmm? mAcpiPmBaseAddress + mAcpiHwReducedSleepCtl should be treated equal here (zero both or zero none). I think explicitly zeroing is not needed, the variables should be in a zero-initialized memory block. > - IoBitFieldWrite16 (mAcpiPmBaseAddress + 4, 10, 13, 0); > - IoOr16 (mAcpiPmBaseAddress + 4, BIT13); > + if (mAcpiPmBaseAddress == 0) { if (mAcpiHwReducedSleepCtl) > + IoWrite8 (mAcpiHwReducedSleepCtl, 5 << 2 | 1 << 5); take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#84380): https://edk2.groups.io/g/devel/message/84380 Mute This Topic: https://groups.io/mt/87508375/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-