Hi,
1. Do you try to update PcdBootManagerMenuFile to point to
BootManagerMenuApp.inf and the test again?
I think following change may not meet above scenario as it will not report
ready to boot status code in such case.
2. I am wondering could we reuse EFI_SW_PC_USER_SETUP status code or add a new
status code for BootManagerMenuApp.inf to do the HOOK.
As the hot key may be different per platforms, hook different key pressed
seems not very reasonable.
Thanks,
Dandan
> -----Original Message-----
> From: Ke, Bo-ChangX <[email protected]>
> Sent: Friday, December 10, 2021 3:34 PM
> To: [email protected]
> Cc: Chaganty, Rangasai V <[email protected]>; Liming Gao
> <[email protected]>; Bi, Dandan <[email protected]>
> Subject: [PATCH] [PATCH v2][Edk2 Platform] UserAuthFeaturePkg: Add boot
> menu return status code to trigger function.
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=3764
>
> BIOS password is not required when overriding boot device via F7 hotkey.
> Add boot menu return status code in callback function for ReportStatusCode()
> notification.
>
> Signed-off-by: Bo Chang Ke <[email protected]>
> Cc: Sai Chaganty <[email protected]>
> Cc: Liming Gao <[email protected]>
> Cc: Dandan Bi <[email protected]>
> Cc: Bo Chang Ke <[email protected]>
> ---
> .../UserAuthenticationDxe.c | 14 ++++++++++++--
> 1 file changed, 12 insertions(+), 2 deletions(-)
>
> diff --git
> a/Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDx
> eSmm/UserAuthenticationDxe.c
> b/Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDx
> eSmm/UserAuthenticationDxe.c
> index bba2057a96..382d891711 100644
> ---
> a/Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthenticationDx
> eSmm/UserAuthenticationDxe.c
> +++
> b/Features/Intel/UserInterface/UserAuthFeaturePkg/UserAuthentication
> +++ DxeSmm/UserAuthenticationDxe.c
> @@ -13,6 +13,7 @@ EFI_EVENT mExitBootServicesEvent
> =
> NULL;
> EFI_RSC_HANDLER_PROTOCOL *mRscHandlerProtocol = NULL;
> USER_AUTHENTICATION_PRIVATE_DATA *mUserAuthenticationData =
> NULL;
> EFI_SMM_COMMUNICATION_PROTOCOL *mSmmCommunication =
> NULL;
> +BOOLEAN mHotKeyF7pressed = FALSE;
>
> EFI_GUID mUserAuthenticationVendorGuid =
> USER_AUTHENTICATION_FORMSET_GUID; HII_VENDOR_DEVICE_PATH
> mHiiVendorDevicePath = { @@ -352,10 +353,19 @@ CheckForPassword (
> IN EFI_STATUS_CODE_DATA *Data OPTIONAL
> )
> {
> - BOOLEAN PasswordSet;
> + BOOLEAN PasswordSet;
> + EFI_INPUT_KEY Key;
> + EFI_STATUS Status = EFI_SUCCESS;
>
> + Status = gST->ConIn->ReadKeyStroke (gST->ConIn, &Key);
> +
> + if (Key.ScanCode == SCAN_F7 && IsPasswordInstalled()) {
> + mHotKeyF7pressed = TRUE;
> + }
> if (((CodeType & EFI_STATUS_CODE_TYPE_MASK) == EFI_PROGRESS_CODE)
> &&
> - (Value == (EFI_SOFTWARE_DXE_BS_DRIVER |
> EFI_SW_PC_USER_SETUP))) {
> + (((Value == (EFI_SOFTWARE_DXE_BS_DRIVER |
> EFI_SW_DXE_BS_PC_READY_TO_BOOT_EVENT)) && mHotKeyF7pressed) ||
> + (Value == (EFI_SOFTWARE_DXE_BS_DRIVER |
> EFI_SW_PC_USER_SETUP)))) {
> + mHotKeyF7pressed = FALSE;
> //
> // Check whether enter setup page.
> //
> --
> 2.32.0.windows.1
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#84784): https://edk2.groups.io/g/devel/message/84784
Mute This Topic: https://groups.io/mt/87640146/21656
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-
