On 2022/1/20 10:30, Chang, Abner (HPS SW/FW Technologist) wrote: > Hi Wenyi, > Could you please create PR for this change? So we can have core CI on this > patch and I can also merge this patch later when the core CI is finished > successfully. > Just send me the link to PR once you create it. >
Sure, here's the link. https://github.com/tianocore/edk2/pull/2429 Thanks Wenyi > Thanks > Abner > ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ > *From:* xiewenyi (A) <[email protected]> > *Sent:* Wednesday, January 19, 2022 3:39 PM > *To:* Chang, Abner (HPS SW/FW Technologist) <[email protected]>; > [email protected] <[email protected]>; Wang, Nickle (Server BIOS) > <[email protected]> > *Cc:* [email protected] <[email protected]> > *Subject:* Re: [PATCH EDK2 v1 0/1] RedfishPkg/RedfishRestExDxe:Simplify > status check > > > > On 2022/1/19 15:29, Chang, Abner (HPS SW/FW Technologist) wrote: >> Hi Wenyi, >> May I know what is the problem you encountered and what environment causes >> the issue? Is that under edk2 emulation or the real Redfish service? >> > Hi Abner, > I didn't encounter any issue and there's no functional change in this patch, > just try to simplify the code. Please review whether it's OK or not. > > Thanks > Wenyi >> Thanks >> Abner >> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ >> *From:* Wenyi Xie <[email protected]> >> *Sent:* Wednesday, January 19, 2022 2:12 PM >> *To:* [email protected] <[email protected]>; Chang, Abner (HPS SW/FW >> Technologist) <[email protected]>; Wang, Nickle (Server BIOS) >> <[email protected]> >> *Cc:* [email protected] <[email protected]>; >> [email protected] <[email protected]> >> *Subject:* [PATCH EDK2 v1 0/1] RedfishPkg/RedfishRestExDxe:Simplify status >> check >> >> Main Changes : >> 1.Remove redundant if statement. >> >> Wenyi Xie (1): >> RedfishPkg/RedfishRestExDxe:Simplify status check >> >> RedfishPkg/RedfishRestExDxe/RedfishRestExImpl.c | 38 +++++++++----------- >> 1 file changed, 17 insertions(+), 21 deletions(-) >> >> -- >> 2.20.1.windows.1 >> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#85864): https://edk2.groups.io/g/devel/message/85864 Mute This Topic: https://groups.io/mt/88529321/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
