Hello, I think we have encountered some devices that will take as long as 1 second to respond.
How about adding a new PCD called gEfiMdeModulePkgTokenSpaceGuid.PcdSdMmcGenericTimeoutValue (in microsecond unit) in MdeModulePkg.dec '[PcdsFixedAtBuild, PcdsPatchableInModule]' section? Please leave the default PCD value as 1000000 (1 second) and you can customize the value in your own platform DSC file. Also added MdeModulePkg maintainers to check if they have concern for adding a new PCD. Best Regards, Hao Wu > -----Original Message----- > From: Sean Rhodes <[email protected]> > Sent: Friday, February 11, 2022 5:25 AM > To: [email protected] > Cc: Wu, Hao A <[email protected]>; Matt DeVillier > <[email protected]> > Subject: [PATCH 09/18] SdMmcPciDxe: Reduce timeout for SD card reset > > From: Matt DeVillier <[email protected]> > > Previous 1s timeout causeed stalls on boot splash with no benefit. > Reduced to 100ms and no interruptions to boot when no SD card inserted. > > Signed-off-by: Matt DeVillier <[email protected]> > --- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h > index 85e09cf114..81fae8e262 100644 > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h > @@ -49,7 +49,7 @@ extern EDKII_SD_MMC_OVERRIDE *mOverride; > // > > // Generic time out value, 1 microsecond as unit. > > // > > -#define SD_MMC_HC_GENERIC_TIMEOUT 1 * 1000 * 1000 > > +#define SD_MMC_HC_GENERIC_TIMEOUT 1 * 1000 * 100 > > > > // > > // SD/MMC async transfer timer interval, set by experience. > > -- > 2.32.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86603): https://edk2.groups.io/g/devel/message/86603 Mute This Topic: https://groups.io/mt/89056094/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
