On Fri, 11 Feb 2022 at 02:14, gaoliming <gaolim...@byosoft.com.cn> wrote:
>
> Ard:
> I am OK to merge this issue for this stable tag. It is a clear bug fix.
>
Merged as #2523
Thanks all,
> > -----邮件原件-----
> > 发件人: Ard Biesheuvel <a...@kernel.org>
> > 发送时间: 2022年2月10日 17:18
> > 收件人: edk2-devel-groups-io <devel@edk2.groups.io>; Rebecca Cran
> > <quic_rc...@quicinc.com>; Liming Gao (Byosoft address)
> > <gaolim...@byosoft.com.cn>
> > 抄送: James Bottomley <j...@linux.ibm.com>; Min Xu
> > <min.m...@intel.com>; Jiewen Yao <jiewen....@intel.com>; Tom Lendacky
> > <thomas.lenda...@amd.com>; Jordan Justen <jordan.l.jus...@intel.com>;
> > Ard Biesheuvel <ardb+tianoc...@kernel.org>; Erdem Aktas
> > <erdemak...@google.com>; Michael Roth <michael.r...@amd.com>; Gerd
> > Hoffmann <kra...@redhat.com>; Brijesh Singh <brijesh.si...@amd.com>
> > 主题: Re: [edk2-devel] [PATCH v2 1/1] OvmfPkg/VmgExitLib: Fix uninitialized
> > variable warning with XCODE5
> >
> > On Thu, 10 Feb 2022 at 10:17, Ard Biesheuvel <a...@kernel.org> wrote:
> > >
> > > (+ Liming)
> > >
> >
> > ... for real this time.
> >
> > > On Fri, 4 Feb 2022 at 21:28, Rebecca Cran <quic_rc...@quicinc.com>
> > wrote:
> > > >
> > > > XCODE5 reported the following warning:
> > > >
> > > > OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c:1895:12: note:
> > > > uninitialized use occurs here
> > > > Compacted
> > > > ^^^^^^^^^
> > > >
> > > > Initialize the 'Compacted' variable to fix the warning.
> > > >
> > > > Signed-off-by: Rebecca Cran <quic_rc...@quicinc.com>
> > > > ---
> > > > OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c | 1 +
> > > > 1 file changed, 1 insertion(+)
> > > >
> > > > diff --git a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
> > b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
> > > > index a40a31f7c275..ccb1300690fa 100644
> > > > --- a/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
> > > > +++ b/OvmfPkg/Library/VmgExitLib/VmgExitVcHandler.c
> > > > @@ -1872,6 +1872,7 @@ GetCpuidFw (
> > > > UINT32 XSaveSize;
> > > >
> > > > XssMsr.Uint64 = 0;
> > > > + Compacted = 0;
> > >
> > > This should be FALSE not 0. I will fix this up before merging.
> > >
> > > Liming: is it ok if I merge this today?
> > >
> > >
> > > > if (EcxIn == 1) {
> > > > /*
> > > > * The PPR and APM aren't clear on what size should be
> > encoded in
> > > > --
> > > > 2.34.1
> > > >
> > > >
> > > >
> > > >
> > > >
> > > >
>
>
>
>
>
>
>
-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#86683): https://edk2.groups.io/g/devel/message/86683
Mute This Topic: https://groups.io/mt/89157797/21656
Group Owner: devel+ow...@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com]
-=-=-=-=-=-=-=-=-=-=-=-
