3 inline comments below:
> -----Original Message----- > From: Sean Rhodes <[email protected]> > Sent: Friday, February 18, 2022 3:24 PM > To: [email protected] > Cc: Dong, Guo <[email protected]>; Matt DeVillier > <[email protected]>; Wu, Hao A <[email protected]>; Ni, Ray > <[email protected]>; Wang, Jian J <[email protected]>; Gao, Liming > <[email protected]>; Rhodes, Sean <[email protected]> > Subject: [PATCH 1/2] MdeModulePkg/SdMmcPciHcDxe: Make timeout for > SD card configurable > > From: Matt DeVillier <[email protected]> > > The default 1s timeout can delay boot splash on some hardware with no > benefit. > > Cc: Hao A Wu <[email protected]> > Cc: Ray Ni <[email protected]> > Cc: Jian J Wang <[email protected]> > Cc: Liming Gao <[email protected]> > Signed-off-by: Matt DeVillier <[email protected]> > Signed-off-by: Sean Rhodes <[email protected]> > --- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h | 3 ++- > MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf | 4 ++++ > MdeModulePkg/Library/BrotliCustomDecompressLib/brotli | 2 +- > MdeModulePkg/MdeModulePkg.dec | 4 ++++ > MdeModulePkg/MdeModulePkg.uni | 4 ++++ > 5 files changed, 15 insertions(+), 2 deletions(-) > > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h > index 85e09cf114..b76c7cffa2 100644 > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h > @@ -24,6 +24,7 @@ SPDX-License-Identifier: BSD-2-Clause-Patent > #include <Library/MemoryAllocationLib.h> > > #include <Library/UefiLib.h> > > #include <Library/DevicePathLib.h> > > +#include <Library/PcdLib.h> > > > > #include <Protocol/DevicePath.h> > > #include <Protocol/PciIo.h> > > @@ -49,7 +50,7 @@ extern EDKII_SD_MMC_OVERRIDE *mOverride; > // > > // Generic time out value, 1 microsecond as unit. > > // > > -#define SD_MMC_HC_GENERIC_TIMEOUT 1 * 1000 * 1000 > > +#define SD_MMC_HC_GENERIC_TIMEOUT (PcdGet32 > (PcdSdMmcGenericTimeoutValue)) > > > > // > > // SD/MMC async transfer timer interval, set by experience. > > diff --git a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf > b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf > index 453ecde7fd..a9d05736d7 100644 > --- a/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf > +++ b/MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf > @@ -56,6 +56,7 @@ > BaseLib > > UefiDriverEntryPoint > > DebugLib > > + PcdLib > > > > [Protocols] > > gEdkiiSdMmcOverrideProtocolGuid ## SOMETIMES_CONSUMES > > @@ -68,3 +69,6 @@ > > > [UserExtensions.TianoCore."ExtraFiles"] > > SdMmcPciHcDxeExtra.uni > > + > > +[Pcd.IA32,Pcd.X64] 1. "[Pcd]" should be fine. > > + gEfiMdeModulePkgTokenSpaceGuid.PcdSdMmcGenericTimeoutValue > ## CONSUMES 2. Could you please help to run the PatchCheck.py to check your patch before sending out: py BaseTools/Scripts/PatchCheck.py -1 Checking git commit: HEAD MdeModulePkg/SdMmcPciHcDxe: Make timeout for SD card configurable The commit message format passed all checks. Code format is not valid: * Tab character used File: MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.inf Line: gEfiMdeModulePkgTokenSpaceGuid.PcdSdMmcGenericTimeoutValue ## CONSUMES > > diff --git a/MdeModulePkg/Library/BrotliCustomDecompressLib/brotli > b/MdeModulePkg/Library/BrotliCustomDecompressLib/brotli > index f4153a09f8..666c3280cc 160000 > --- a/MdeModulePkg/Library/BrotliCustomDecompressLib/brotli > +++ b/MdeModulePkg/Library/BrotliCustomDecompressLib/brotli > @@ -1 +1 @@ > -Subproject commit f4153a09f87cbb9c826d8fc12c74642bb2d879ea > +Subproject commit 666c3280cc11dc433c303d79a83d4ffbdd12cc8d 3. Why change in BrotliCustomDecompressLib is needed for this patch? Best Regards, Hao Wu > diff --git a/MdeModulePkg/MdeModulePkg.dec > b/MdeModulePkg/MdeModulePkg.dec > index 463e889e9a..40601c9583 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -1559,6 +1559,10 @@ > # @Prompt Maximum permitted FwVol section nesting depth (exclusive). > > > gEfiMdeModulePkgTokenSpaceGuid.PcdFwVolDxeMaxEncapsulationDepth| > 0x10|UINT32|0x00000030 > > > > + ## Indicates the default timeout value for SD/MMC Host Controller > operations in microseconds. > > + # @Prompt SD/MMC Host Controller Operations Timeout (us). > > + > gEfiMdeModulePkgTokenSpaceGuid.PcdSdMmcGenericTimeoutValue|1000 > 000|UINT32|0x00000031 > > + > > [PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] > > ## This PCD defines the Console output row. The default value is 25 > according to UEFI spec. > > # This PCD could be set to 0 then console output would be at max column > and max row. > > diff --git a/MdeModulePkg/MdeModulePkg.uni > b/MdeModulePkg/MdeModulePkg.uni > index 27889a7280..b070f15ff2 100644 > --- a/MdeModulePkg/MdeModulePkg.uni > +++ b/MdeModulePkg/MdeModulePkg.uni > @@ -1173,6 +1173,10 @@ > > " TRUE - Capsule In Ram is > supported.<BR>" > > > " FALSE - Capsule In Ram is not > supported." > > > > +#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSdMmcGenericTimeoutValue > _PROMPT #language en-US "SD/MMC Host Controller Operations Timeout > (us)." > > + > > +#string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSdMmcGenericTimeoutValue > _HELP #language en-US "Indicates the default timeout value for SD/MMC > Host Controller operations in microseconds." > > + > > #string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCodRelocationDevPath_PRO > MPT #language en-US "Capsule On Disk relocation device path." > > > > #string > STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCodRelocationDevPath_HELP > #language en-US "Full device path of platform specific device to store > Capsule On Disk temp relocation file.<BR>" > > -- > 2.32.0 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#86947): https://edk2.groups.io/g/devel/message/86947 Mute This Topic: https://groups.io/mt/89228249/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
