Merged - https://github.com/tianocore/edk2/pull/2779
> -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Yao, Jiewen > Sent: Thursday, April 14, 2022 10:32 PM > To: devel@edk2.groups.io; mikub...@linux.microsoft.com > Cc: Wang, Jian J <jian.j.w...@intel.com>; Lu, Xiaoyu1 <xiaoyu1...@intel.com>; > Jiang, Guomin <guomin.ji...@intel.com> > Subject: Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/TlsLibNull: Remove > MU_CHANGE comment markers > > Ah, thanks for the reminder. I overlooked this one. > > Reviewed-by: Jiewen Yao <jiewen....@intel.com> > > > -----Original Message----- > > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael > > Kubacki > > Sent: Thursday, April 14, 2022 10:19 PM > > To: devel@edk2.groups.io > > Cc: Yao, Jiewen <jiewen....@intel.com>; Wang, Jian J > <jian.j.w...@intel.com>; > > Lu, Xiaoyu1 <xiaoyu1...@intel.com>; Jiang, Guomin <guomin.ji...@intel.com> > > Subject: Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/TlsLibNull: Remove > > MU_CHANGE comment markers > > > > Please review this patch when possible. It is just removing two > > irrelevant comments. > > > > Thanks, > > Michael > > > > On 4/5/2022 8:50 PM, Michael Kubacki wrote: > > > From: Michael Kubacki <michael.kuba...@microsoft.com> > > > > > > MU_CHANGE tags are used in a different project (Project Mu) to > > > highlight deviations from Tianocore. Therefore, the comments are > > > not needed when the changes are present in a Tianocore repository. > > > > > > Cc: Jiewen Yao <jiewen....@intel.com> > > > Cc: Jian J Wang <jian.j.w...@intel.com> > > > Cc: Xiaoyu Lu <xiaoyu1...@intel.com> > > > Cc: Guomin Jiang <guomin.ji...@intel.com> > > > Signed-off-by: Michael Kubacki <michael.kuba...@microsoft.com> > > > --- > > > CryptoPkg/Library/TlsLibNull/TlsConfigNull.c | 4 ---- > > > 1 file changed, 4 deletions(-) > > > > > > diff --git a/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c > > b/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c > > > index b5d9aca06535..03726fd7264c 100644 > > > --- a/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c > > > +++ b/CryptoPkg/Library/TlsLibNull/TlsConfigNull.c > > > @@ -130,8 +130,6 @@ TlsSetVerify ( > > > ASSERT (FALSE); > > > } > > > > > > -// MU_CHANGE - Proposed fixes for TCBZ960, invalid domain name (CN) > > accepted. [BEGIN] > > > - > > > /** > > > Set the specified host name to be verified. > > > > > > @@ -156,8 +154,6 @@ TlsSetVerifyHost ( > > > return EFI_UNSUPPORTED; > > > } > > > > > > -// MU_CHANGE - Proposed fixes for TCBZ960, invalid domain name (CN) > > accepted. [END] > > > - > > > /** > > > Sets a TLS/SSL session ID to be used during TLS/SSL connect. > > > > > > > > > > > > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#88911): https://edk2.groups.io/g/devel/message/88911 Mute This Topic: https://groups.io/mt/90280180/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
