I am not the reviewer for the changes under EmulatorPkg other than Redfish stuff. However, I have no problem with the entire patch set, so does the change under for EmulatorPkg.
Reviewed-by: Abner Chang <abner.ch...@hpe.com> > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Michael > Kubacki > Sent: Thursday, April 21, 2022 6:52 AM > To: devel@edk2.groups.io; Andrew Fish <af...@apple.com>; Ray Ni > <ray...@intel.com>; Chang, Abner (HPS SW/FW Technologist) > <abner.ch...@hpe.com>; Wang, Nickle (Server BIOS) > <nickle.w...@hpe.com> > Subject: Re: [edk2-devel] [PATCH v4 6/8] EmulatorPkg: Add > VariableFlashInfoLib > > Hi EmulatorPkg maintainers, > > This is the only package in the series that has not given a review yet. > Can you please help review it? > > Thanks, > Michael > > On 4/12/2022 12:29 PM, Michael Kubacki wrote: > > From: Michael Kubacki <michael.kuba...@microsoft.com> > > > > > REF:INVALID URI REMOVED. > cgi?id=3479__;!!NpxR!3XNUZ5NC9M4mSbD7tIR6y_88TLasCu1rZ5-dyKIh2qyl- > RQ7xt-gSz5UZ-tm4Zs$ > > > > Adds an instance of VariableFlashInfoLib to the platform build as > > it is a new library class introduced in MdeModulePkg. > > > > Cc: Andrew Fish <af...@apple.com> > > Cc: Ray Ni <ray...@intel.com> > > Cc: Abner Chang <abner.ch...@hpe.com> > > Cc: Nickle Wang <nickle.w...@hpe.com> > > Signed-off-by: Michael Kubacki <michael.kuba...@microsoft.com> > > --- > > EmulatorPkg/EmulatorPkg.dsc | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/EmulatorPkg/EmulatorPkg.dsc b/EmulatorPkg/EmulatorPkg.dsc > > index 554c13ddb500..4cf886b9eac7 100644 > > --- a/EmulatorPkg/EmulatorPkg.dsc > > +++ b/EmulatorPkg/EmulatorPkg.dsc > > @@ -122,6 +122,7 @@ [LibraryClasses] > > VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf > > > VariablePolicyLib|MdeModulePkg/Library/VariablePolicyLib/VariablePolicyLi > bRuntimeDxe.inf > > > VariablePolicyHelperLib|MdeModulePkg/Library/VariablePolicyHelperLib/Va > riablePolicyHelperLib.inf > > + > VariableFlashInfoLib|MdeModulePkg/Library/BaseVariableFlashInfoLib/Base > VariableFlashInfoLib.inf > > SortLib|MdeModulePkg/Library/BaseSortLib/BaseSortLib.inf > > ShellLib|ShellPkg/Library/UefiShellLib/UefiShellLib.inf > > FileHandleLib|MdePkg/Library/UefiFileHandleLib/UefiFileHandleLib.inf > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#89168): https://edk2.groups.io/g/devel/message/89168 Mute This Topic: https://groups.io/mt/90595285/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
