The previous patch created a new instance SecTpmMeasurementLibTdx, which is not a best idea.
If we can use the existing instance, there is no need to create a new one. Just create a new instance. Thank you Yao Jiewen > -----Original Message----- > From: Gerd Hoffmann <[email protected]> > Sent: Tuesday, June 7, 2022 6:35 PM > To: Xu, Min M <[email protected]> > Cc: [email protected]; Yao, Jiewen <[email protected]>; Wang, Jian J > <[email protected]>; Aktas, Erdem <[email protected]>; James > Bottomley <[email protected]>; Tom Lendacky <[email protected]> > Subject: Re: [PATCH 0/3] Introduce SecTpmMeasurementLibTdx > > On Sun, Jun 05, 2022 at 09:02:45AM +0800, Min Xu wrote: > > SecTpmMeasurementLibTdx is an instance of TpmMeasurement lib in SEC > phase. > > It provides RTMR based measurement functions for Intel Tdx guest. > > > > Commit a708536dce introduces SecMeasurementLibTdx which provides the > same > > functions. But it is not an instance of TpmMeasurementLib. > > We have updated DxeTpmMeasurementLib (which is an instance of > > TpmMeasurementLib) to support RTMR based measurement. To make the > design > > consistent, SecTpmMeasurementLibTdx is introduced. After that > > SecMeasurementLibTdx is removed. > > So, what is the difference? Just make the calling convention compatible > with TpmMeasurementLib? > > take care, > Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90288): https://edk2.groups.io/g/devel/message/90288 Mute This Topic: https://groups.io/mt/91551450/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
