Thank you for taking care of the follow up Benjamin. Reviewed-by: Ankit Sinha <[email protected]>
> -----Original Message----- > From: [email protected] <[email protected]> On Behalf Of > Benjamin Doron > Sent: Wednesday, June 15, 2022 10:42 AM > To: [email protected] > Cc: Chiu, Chasel <[email protected]>; Desimone, Nathaniel L > <[email protected]>; Oram, Isaac W > <[email protected]>; Gao, Liming <[email protected]>; > Dong, Eric <[email protected]>; Sinha, Ankit <[email protected]> > Subject: [edk2-devel] [edk2-platforms][PATCH v1] MinPlatformPkg: Update > FADT-related PCD defaults to restore behaviour > > Commit f427247 (MinPlatformPkg: Add PCDs to update FADT entries from > board package) modified AcpiPlatform flow, altering the FADT for all > platforms. Now, because `FadtHeader->Gpe0BlkLen == 0`, the Linux kernel > prints "irq 9: nobody cared ..." - GPE status cannot be retrieved and at least > ACPI SCIs cannot be handled correctly. As the size of this register is the > same > on Skylake/Kabylake and TigerLake, update the PCD default value. > > Several FADT register block AccessSize PCDs are updated as well. These fields > too are the same between Skylake/Kabylake and TigerLake. However, other > fields differ between platforms, such as GPE0 address and the removal of > PM{1,2}* addresses, which should be handled in a follow-up. > > Cc: Chasel Chiu <[email protected]> > Cc: Nate DeSimone <[email protected]> > Cc: Isaac Oram <[email protected]> > Cc: Liming Gao <[email protected]> > Cc: Eric Dong <[email protected]> > Cc: Ankit Sinha <[email protected]> > Signed-off-by: Benjamin Doron <[email protected]> > --- > Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec | 12 ++++++------ > 1 file changed, 6 insertions(+), 6 deletions(-) > > diff --git a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > index 68ab1d702d6a..9549c355b122 100644 > --- a/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > +++ b/Platform/Intel/MinPlatformPkg/MinPlatformPkg.dec > @@ -123,18 +123,18 @@ > > gMinPlatformPkgTokenSpaceGuid.PcdAcpiPm2ControlBlockAddress|0x1850 > |UINT16|0x00010039 > gMinPlatformPkgTokenSpaceGuid.PcdAcpiPmTimerBlockAddress|0x1808|UI > NT16|0x0001003A > gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockAddress|0x1880|UINT1 > 6|0x0001003B- > gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockLength|0x00|UINT8|0x > 0001003C+ > gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe0BlockLength|0x20|UINT8|0x > 0001003C > gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1BlockAddress|0x0000|UINT1 > 6|0x0001003D > gMinPlatformPkgTokenSpaceGuid.PcdAcpiGpe1Base|0x00|UINT8|0x000100 > 40- > gMinPlatformPkgTokenSpaceGuid.PcdAcpiResetRegAccessSize|0x00|UINT8 > |0x00010042+ > gMinPlatformPkgTokenSpaceGuid.PcdAcpiResetRegAccessSize|0x01|UINT8 > |0x00010042 - > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1aEvtBlkAccessSize|0x00|UI > NT8|0x00010043+ > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1aEvtBlkAccessSize|0x02|UI > NT8|0x00010043 > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1bEvtBlkAccessSize|0x00|UI > NT8|0x00010044- > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1aCntBlkAccessSize|0x00|UI > NT8|0x00010045+ > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1aCntBlkAccessSize|0x02|UI > NT8|0x00010045 > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm1bCntBlkAccessSize|0x00|UI > NT8|0x00010046 > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPm2CntBlkAccessSize|0x00|UIN > T8|0x00010047- > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPmTmrBlkAccessSize|0x00|UINT > 8|0x00010048- > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe0BlkAccessSize|0x00|UINT8 > |0x00010049+ > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXPmTmrBlkAccessSize|0x03|UINT > 8|0x00010048+ > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe0BlkAccessSize|0x01|UINT8 > |0x00010049 > gMinPlatformPkgTokenSpaceGuid.PcdAcpiXGpe1BlkAccessSize|0x00|UINT8 > |0x0001004A > gMinPlatformPkgTokenSpaceGuid.PcdAcpiSleepControlRegAddressSpaceId| > 0x00|UINT8|0x0001004B-- > 2.36.1 > > > > -=-=-=-=-=-= > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#90537): https://edk2.groups.io/g/devel/message/90537 > Mute This Topic: https://groups.io/mt/91781863/1772825 > Group Owner: [email protected] > Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] > -=-=-=-=-=-= > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90538): https://edk2.groups.io/g/devel/message/90538 Mute This Topic: https://groups.io/mt/91781863/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
