Reviewed-by: Bob Feng <[email protected]> -----Original Message----- From: Chen, Christine <[email protected]> Sent: Friday, June 24, 2022 9:25 AM To: [email protected]; [email protected]; Feng, Bob C <[email protected]>; Gao, Liming <[email protected]> Subject: RE: [edk2-devel] [PATCH 1/1] BaseTools/Ecc: Fix grammar in Ecc error message
Reviewed-by: Yuwei Chen<[email protected]> > -----Original Message----- > From: [email protected] <[email protected]> On Behalf Of Rebecca > Cran > Sent: Monday, June 20, 2022 6:07 AM > To: [email protected]; Feng, Bob C <[email protected]>; Gao, > Liming <[email protected]>; Chen, Christine > <[email protected]> > Cc: Rebecca Cran <[email protected]> > Subject: [edk2-devel] [PATCH 1/1] BaseTools/Ecc: Fix grammar in Ecc > error message > > Signed-off-by: Rebecca Cran <[email protected]> > --- > BaseTools/Source/Python/Ecc/c.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/BaseTools/Source/Python/Ecc/c.py > b/BaseTools/Source/Python/Ecc/c.py > index 4a82e5e76003..61ad084fcc5b 100644 > --- a/BaseTools/Source/Python/Ecc/c.py > +++ b/BaseTools/Source/Python/Ecc/c.py > @@ -2612,8 +2612,8 @@ def > CheckFunctionHeaderConsistentWithDoxygenComment(FuncModifier, > FuncHeader, Fu > > > if Tag.find(ParamName) == -1 and ParamName != 'VOID' and > ParamName != 'void': > - ErrorMsgList.append('Line %d : in Comment, <%s> does NOT > consistent with parameter name %s ' % (CommentStartLine, > (TagPartList[0] + ' ' + TagPartList[1]).replace('\n', '').replace('\r', ''), > ParamName)) > - PrintErrorMsg(ERROR_DOXYGEN_CHECK_FUNCTION_HEADER, 'in > Comment, <%s> does NOT consistent with parameter name %s ' % > ((TagPartList[0] + ' ' + TagPartList[1]).replace('\n', > '').replace('\r', ''), ParamName), TableName, CommentId) > + ErrorMsgList.append('Line %d : in Comment, <%s> is > + NOT > consistent with parameter name %s ' % (CommentStartLine, > (TagPartList[0] + ' ' + TagPartList[1]).replace('\n', > '').replace('\r', ''), ParamName)) > + PrintErrorMsg(ERROR_DOXYGEN_CHECK_FUNCTION_HEADER, > + 'in > Comment, <%s> is NOT consistent with parameter name %s ' % > ((TagPartList[0] + ' ' + TagPartList[1]).replace('\n', > '').replace('\r', ''), ParamName), TableName, CommentId) > Index += 1 > > if Index < ParamNumber: > -- > 2.35.3 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#90761): https://edk2.groups.io/g/devel/message/90761 Mute This Topic: https://groups.io/mt/91866114/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
