Replied as below
Thanks, James -----Original Message----- From: Ni, Ray <[email protected]> Sent: Monday, July 4, 2022 11:34 AM To: Lu, James <[email protected]>; [email protected] Cc: Dong, Guo <[email protected]>; Guo, Gua <[email protected]> Subject: RE: [PATCH] UefiPayloadPkg: Add macro to support selective driver in UPL > > +!if $(GENERIC_MEMORY_TEST_ENABLE) == TRUE > > + > MdeModulePkg/Universal/MemoryTest/GenericMemoryTestDxe/Generic > MemoryTestDxe.inf > > +!endif > > +!if $(NULL_MEMORY_TEST_ENABLE) == TRUE > > > MdeModulePkg/Universal/MemoryTest/NullMemoryTestDxe/NullMemoryT > estDxe.inf > > +!endif 1. Is there a configuration that both GENERIC and NULL memory test is FALSE? If no, can we add a macro like "MEMORY_TEST" and its value could be "GENERIC" or "NULL"? [James] Will resolve in patch v2 > +!if $(ATA_ENABLE) == TRUE > > MdeModulePkg/Bus/Pci/SataControllerDxe/SataControllerDxe.inf > > MdeModulePkg/Bus/Ata/AtaBusDxe/AtaBusDxe.inf > > MdeModulePkg/Bus/Ata/AtaAtapiPassThru/AtaAtapiPassThru.inf 2. AtaAtapiPassThru also produces "gEfiExtScsiPassThruProtocolGuid" which is used by ScsiBusDxe. So, maybe we need to always include AtaAtapiPassThru driver. [James] This is to align client case that AtaAtapiPassThru.inf will not be included while ATA_ENABLE == FALSE And ScsiBusDxe is taken care the flow while gEfiExtScsiPassThruProtocolGuid not existing > > # > > # Usb Support > > @@ -671,7 +685,9 @@ > !if $(PS2_KEYBOARD_ENABLE) == TRUE > > MdeModulePkg/Bus/Isa/Ps2KeyboardDxe/Ps2KeyboardDxe.inf > > !endif > > +!if $(PS2_MOUSE_ENABLE) == TRUE > > MdeModulePkg/Bus/Isa/Ps2MouseDxe/Ps2MouseDxe.inf > > +!endif > > > > # > > # Console Support > > @@ -742,12 +758,14 @@ > # This should be FALSE for compiling the dynamic command. > > gEfiShellPkgTokenSpaceGuid.PcdShellLibAutoInitialize|FALSE > > } > > +!if $(PERFORMANCE_MEASUREMENT_ENABLE) == TRUE 3. Thanks for catching that. -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91059): https://edk2.groups.io/g/devel/message/91059 Mute This Topic: https://groups.io/mt/92047211/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
