Thanks Nate! I have sent V2 accordingly, please help to review again.
> -----Original Message----- > From: Desimone, Nathaniel L <nathaniel.l.desim...@intel.com> > Sent: Monday, July 18, 2022 4:53 PM > To: Chiu, Chasel <chasel.c...@intel.com>; devel@edk2.groups.io > Cc: Oram, Isaac W <isaac.w.o...@intel.com>; Gao, Liming > <gaolim...@byosoft.com.cn>; Dong, Eric <eric.d...@intel.com> > Subject: RE: [PATCH 0/2] MinPlatformPkg: FspResetType support for X64 build. > > Hi Chasel, > > Please change the function signature for CallFspWrapperResetSystem() to take a > EFI_STATUS as input. UINTN is certainly better than UINT32, but the actual > data > type defined in the FSP specification is EFI_STATUS. Also, that is the data > type > that FspmWrapperPeim.c and FspsWrapperPeim.c is passing in. Using > EFI_STATUS instead of UINTN would prevent us from having to do > CallFspWrapperResetSystem ((UINTN)Status); in those 2 files. > > Thanks, > Nate > > > -----Original Message----- > > From: Chiu, Chasel <chasel.c...@intel.com> > > Sent: Monday, July 18, 2022 3:13 PM > > To: devel@edk2.groups.io > > Cc: Chiu, Chasel <chasel.c...@intel.com>; Desimone, Nathaniel L > > <nathaniel.l.desim...@intel.com>; Oram, Isaac W > > <isaac.w.o...@intel.com>; Gao, Liming <gaolim...@byosoft.com.cn>; > > Dong, Eric <eric.d...@intel.com> > > Subject: [PATCH 0/2] MinPlatformPkg: FspResetType support for X64 build. > > > > FSP_STATUS_RESET_REQUIRED_* will be either 32bit or 64bit basing on > > the build and this patch series extended the support for 64bit build. > > > > Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> > > Cc: Isaac Oram <isaac.w.o...@intel.com> > > Cc: Liming Gao <gaolim...@byosoft.com.cn> > > Cc: Eric Dong <eric.d...@intel.com> > > Signed-off-by: Chasel Chiu <chasel.c...@intel.com> > > > > Chasel Chiu (2): > > MinPlatformPkg/FspWrapper: FspResetType support for X64 build. > > WhitleySiliconPkg: FspResetType support for X64 build. > > > > > > Platform/Intel/MinPlatformPkg/FspWrapper/Library/DxeFspWrapperPlatfor > > mLib/DxeFspWrapperPlatformResetLib.c | 4 ++-- > > Platform/Intel/MinPlatformPkg/FspWrapper/Library/PeiFspWrapperPlatfor > > mLib/PeiFspWrapperPlatformResetLib.c | 4 ++-- > > > > Silicon/Intel/WhitleySiliconPkg/Library/FspWrapperPlatformLib/FspWrapper > > PlatformLib.c | 4 ++-- > > 3 files changed, 6 insertions(+), 6 deletions(-) > > > > -- > > 2.35.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91507): https://edk2.groups.io/g/devel/message/91507 Mute This Topic: https://groups.io/mt/92470479/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
