Pushed as a2763c425e..f5306c2b07 -----Original Message----- From: Desimone, Nathaniel L <nathaniel.l.desim...@intel.com> Sent: Wednesday, July 20, 2022 3:17 PM To: Oram, Isaac W <isaac.w.o...@intel.com>; devel@edk2.groups.io Cc: Gao, Liming <gaolim...@byosoft.com.cn>; Chiu, Chasel <chasel.c...@intel.com> Subject: RE: [edk2-devel][edk2-platforms][PATCH V1 0/5] Resolve GCC compilation warnings
For the series... Reviewed-by: Nate DeSimone <nathaniel.l.desim...@intel.com> > -----Original Message----- > From: Oram, Isaac W <isaac.w.o...@intel.com> > Sent: Thursday, June 30, 2022 5:14 PM > To: devel@edk2.groups.io > Cc: Oram, Isaac W <isaac.w.o...@intel.com>; Desimone, Nathaniel L > <nathaniel.l.desim...@intel.com>; Gao, Liming > <gaolim...@byosoft.com.cn>; Chiu, Chasel <chasel.c...@intel.com> > Subject: [edk2-devel][edk2-platforms][PATCH V1 0/5] Resolve GCC > compilation warnings > > Fix GCC warnings and remove the build flags to ignore them. > > Cc: Nate DeSimone <nathaniel.l.desim...@intel.com> > Cc: Liming Gao <gaolim...@byosoft.com.cn> > Cc: Chasel Chiu <chasel.c...@intel.com> > Signed-off-by: Isaac Oram <isaac.w.o...@intel.com> > > Isaac Oram (5): > IpmiFeaturePkg/GenericIpmi: Fix GCC compilation warnings > WhitleyOpenBoardPkg: Fix GCC warnings > WhitleyOpenBoardPkg: Fix GCC unused variables warnings > WhitleyOpenBoardPkg: Fix GCC unused variables that are set warnings > WhitleyOpenBoardPkg: Remove unnecessary code > > .../GenericIpmi/Common/KcsBmc.c | 8 +-- > .../GenericIpmi/Pei/PeiGenericIpmi.c | 3 +- > .../IpmiPlatformHookLib/IpmiPlatformHookLib.c | 2 +- > .../PeiPlatformHookLib/PeiPlatformHooklib.c | 2 +- > .../Dxe/IioCfgUpdateDxe/IioCfgUpdateDxe.c | 2 +- > .../Dxe/IioCfgUpdateDxe/IioCfgUpdateDxe.inf | 6 +- > .../Dxe/SlotDataUpdateDxe/SlotDataUpdateDxe.c | 2 +- > .../SlotDataUpdateDxe/SlotDataUpdateDxe.inf | 3 +- > .../Dxe/UsbOcUpdateDxe/UsbOcUpdateDxe.c | 2 +- > .../Dxe/UsbOcUpdateDxe/UsbOcUpdateDxe.inf | 3 +- > .../Uba/TypeAowanda/Pei/AcpiTablePcds.c | 2 - > .../Aowanda/Uba/TypeAowanda/Pei/KtiEparam.c | 3 - > .../Aowanda/Uba/TypeAowanda/Pei/PcdData.c | 2 +- > .../Uba/TypeAowanda/Pei/PchEarlyUpdate.c | 2 +- > .../Uba/TypeAowanda/Pei/PeiBoardInitLib.c | 2 +- > .../Uba/TypeAowanda/Pei/PeiBoardInitLib.inf | 11 ++++ > .../Dxe/IioCfgUpdateDxe/IioCfgUpdateDxe.c | 2 +- > .../Dxe/IioCfgUpdateDxe/IioCfgUpdateDxe.inf | 4 ++ > .../Dxe/SlotDataUpdateDxe/SlotDataUpdateDxe.c | 2 +- > .../SlotDataUpdateDxe/SlotDataUpdateDxe.inf | 1 + > .../Dxe/UsbOcUpdateDxe/UsbOcUpdateDxe.c | 2 +- > .../Dxe/UsbOcUpdateDxe/UsbOcUpdateDxe.inf | 1 + > .../TypeBoardPortTemplate/Pei/AcpiTablePcds.c | 3 +- > .../TypeBoardPortTemplate/Pei/IioBifurInit.c | 8 +-- > .../Uba/TypeBoardPortTemplate/Pei/KtiEparam.c | 2 - > .../Pei/PchEarlyUpdate.c | 4 +- > .../Pei/PeiBoardInitLib.c | 2 +- > .../Pei/PeiBoardInitLib.inf | 11 ++++ > .../Dxe/PlatformCpuPolicy/PlatformCpuPolicy.c | 4 +- > .../Features/Acpi/AcpiPlatform/AcpiPlatform.c | 34 +++++------ > .../Acpi/AcpiPlatform/AcpiPlatformHooks.c | 16 +++--- > .../Acpi/AcpiPlatform/AcpiPlatformVTDHooks.c | 37 ++++++------ > .../Pci/Dxe/PciHostBridge/PciHostBridge.c | 5 +- > .../Dxe/PciHostBridge/PciHostBridgeSupport.c | 2 +- > .../Pci/Dxe/PciHostBridge/PciRootBridgeIo.c | 11 +--- > .../Pci/Dxe/PciPlatform/PciPlatform.c | 35 ++++++------ > .../Pci/Dxe/PciPlatform/PciPlatform.inf | 1 + > .../Pci/Dxe/PciPlatform/PciPlatformHooks.c | 16 +++--- > .../WhitleyOpenBoardPkg/Include/Acpi/Fadt.h | 2 +- > .../Include/Dsc/BuildOptions.dsc | 5 +- > .../Include/Library/UbaAcpiUpdateLib.h | 2 - > .../Include/Library/UbaClkGenUpdateLib.h | 2 - > .../Include/Library/UbaGpioPlatformConfig.h | 4 -- > .../Include/Library/UbaGpioUpdateLib.h | 2 - > .../Library/UbaHsioPtssTableConfigLib.h | 3 - > .../Include/Library/UbaIioConfigLib.h | 10 ---- > .../Library/UbaIioPortBifurcationInitLib.h | 3 - > .../Include/Library/UbaOpromUpdateLib.h | 6 -- > .../Include/Library/UbaPcdUpdateLib.h | 2 - > .../Include/Library/UbaPchEarlyUpdateLib.h | 3 - > .../Include/Library/UbaSlotUpdateLib.h | 12 ---- > .../Include/Library/UbaSoftStrapUpdateLib.h | 2 - > .../Library/UbaSystemConfigUpdateLib.h | 3 - > .../Include/Library/UbaUsbOcUpdateLib.h | 2 - > .../IpmiPlatformHookLib/IpmiPlatformHookLib.c | 2 +- > .../PeiPlatformHookLib/PeiPlatformHooklib.c | 2 +- > .../Dxe/IioCfgUpdateDxe/IioCfgUpdateDxe.c | 2 +- > .../Dxe/IioCfgUpdateDxe/IioCfgUpdateDxe.inf | 6 +- > .../Dxe/SlotDataUpdateDxe/SlotDataUpdateDxe.c | 2 +- > .../SlotDataUpdateDxe/SlotDataUpdateDxe.inf | 3 +- > .../Dxe/UsbOcUpdateDxe/UsbOcUpdateDxe.c | 2 +- > .../Dxe/UsbOcUpdateDxe/UsbOcUpdateDxe.inf | 3 +- > .../Uba/TypeJunctionCity/Pei/AcpiTablePcds.c | 4 +- > .../Uba/TypeJunctionCity/Pei/IioBifurInit.c | 3 - > .../Uba/TypeJunctionCity/Pei/KtiEparam.c | 3 - > .../Uba/TypeJunctionCity/Pei/PchEarlyUpdate.c | 4 +- > .../TypeJunctionCity/Pei/PeiBoardInitLib.c | 4 +- > .../TypeJunctionCity/Pei/PeiBoardInitLib.inf | 11 ++++ > .../AcpiPlatformTableLib/AcpiPlatformLib.c | 19 +++---- > .../AcpiPlatformLibApic.c | 56 +------------------ > .../AcpiPlatformLibBdat.c | 12 ++-- > .../AcpiPlatformLibDsdt.c | 4 -- > .../AcpiPlatformLibHmat.c | 8 +-- > .../AcpiPlatformLibMsct.c | 2 +- > .../AcpiPlatformLibNfit.c | 2 +- > .../AcpiPlatformLibPcat.c | 2 +- > .../AcpiPlatformLibPmtt.c | 4 +- > .../AcpiPlatformLibSlit.c | 11 +--- > .../AcpiPlatformLibSrat.c | 4 +- > .../AcpiPlatformLibSsdt.c | 6 +- > .../BoardAcpiLib/SmmBoardAcpiEnableLib.c | 6 +- > .../Library/BoardInitLib/BoardInitDxeLib.c | 6 +- > .../Library/BoardInitLib/BoardInitPreMemLib.c | 18 ++---- > .../MultiPlatSupportLib/MultiPlatSupportLib.c | 51 +++++++---------- > .../PeiPlatformHookLib/PeiPlatformHooklib.c | 6 +- > .../Library/PeiReportFvLib/PeiReportFvLib.c | 4 +- > .../PeiUbaGpioPlatformConfigLib.c | 22 ++++---- > .../Library/PeiUbaPlatLib/PeiUbaPlatLib.inf | 21 +++++++ > .../PeiUbaPlatLib/PeiUbaUsbOcUpdateLib.c | 2 +- > .../PeiUbaPlatLib/UbaBoardSioInfoLib.c | 2 +- > .../PeiUbaPlatLib/UbaClkGenUpdateLib.c | 6 +- > .../PeiUbaPlatLib/UbaClocksConfigLib.c | 2 +- > .../Library/PeiUbaPlatLib/UbaGpioUpdateLib.c | 4 +- > .../PeiUbaPlatLib/UbaHsioPtssTableConfigLib.c | 2 +- > .../PeiUbaPlatLib/UbaIioConfigLibPei.c | 10 ++-- > .../UbaIioPortBifurcationInitLib.c | 2 +- > .../Library/PeiUbaPlatLib/UbaPcdUpdateLib.c | 3 +- > .../PeiUbaPlatLib/UbaPchEarlyUpdateLib.c | 6 +- > .../PeiUbaPlatLib/UbaPchPcieBifurcationLib.c | 2 +- > .../PeiUbaPlatLib/UbaSlotUpdateLibPei.c | 6 +- > .../PeiUbaPlatLib/UbaSoftStrapUpdateLib.c | 5 +- > .../PlatformClocksLib/Pei/PlatformClocksLib.c | 17 +----- > .../Pei/PlatformClocksLib.inf | 2 +- > .../PlatformCmosAccessLib.c | 4 +- > .../Library/PlatformHooksLib/PlatformHooks.c | 8 +-- > .../Library/SetCacheMtrrLib/SetCacheMtrrLib.c | 8 +-- > .../PchPolicyUpdateUsb.c | 2 +- > .../SiliconPolicyUpdateLib.c | 9 +-- > .../SiliconPolicyUpdateLibFsp.c | 2 +- > .../SmmSpiFlashCommonLib/SpiFlashCommon.c | 3 +- > .../Library/UbaGpioInitLib/UbaGpioInitLib.c | 6 +- > .../UbaPlatLib/DxeUbaGpioPlatformConfigLib.c | 4 +- > .../UbaPlatLib/DxeUbaSystemBoardInfoLib.c | 2 +- > .../UbaPlatLib/DxeUbaSystemConfigUpdateLib.c | 2 +- > .../Library/UbaPlatLib/DxeUbaUsbOcUpdateLib.c | 2 +- > .../Library/UbaPlatLib/UbaAcpiUpdateLib.c | 2 +- > .../Library/UbaPlatLib/UbaFpkConfigLib.c | 2 +- > .../Library/UbaPlatLib/UbaIioConfigLib.c | 4 +- > .../Library/UbaPlatLib/UbaOpromUpdateLib.c | 10 ++-- > .../Library/UbaPlatLib/UbaPlatLib.inf | 12 ++++ > .../Library/UbaPlatLib/UbaSlotUpdateLib.c | 4 +- > .../Library/UbaPlatLib/UbaSmbiosUpdateLib.c | 16 +++--- > .../Platform/Dxe/PlatformType/PlatformTypes.c | 5 +- > .../EmulationPlatformInit.c | 2 +- > .../Platform/Pei/PlatformInfo/PlatformInfo.c | 19 +++---- > .../Intel/WhitleyOpenBoardPkg/PlatformPkg.dec | 31 +++++++++- > .../Uba/BoardInit/Dxe/BoardInitDxe.c | 2 +- > .../Uba/CfgDb/Dxe/CfgDbDxe.c | 10 ---- > .../Uba/CfgDb/Pei/CfgDbPei.c | 5 -- > .../SystemBoardInfoDxe/SystemBoardInfoDxe.c | 2 +- > .../SystemConfigUpdateDxe.c | 4 +- > .../SystemConfigUpdateDxe.inf | 1 + > .../Uba/UbaMain/Common/Pei/ClocksConfig.c | 11 +--- > .../UbaMain/Common/Pei/GpioPlatformConfig.c | 4 +- > .../UbaMain/Common/Pei/HsioPtssTableConfig.c | 5 +- > .../UbaMain/Common/Pei/IioPortBifurcation.c | 7 +-- > .../Common/Pei/IioPortBifurcationVer1.c | 12 ++-- > .../Common/Pei/PeiCommonBoardInitLib.c | 2 +- > .../Common/Pei/PeiCommonBoardInitLib.inf | 9 +++ > .../UbaMain/StaticSkuDataDxe/AcpiStaticData.c | 2 - > .../StaticSkuDataDxe/DeviceDataInstall.c | 4 -- > .../StaticSkuDataDxe/StaticSkuDataDxe.c | 2 +- > .../StaticSkuDataDxe/StaticSkuDataDxe.inf | 1 + > .../Dxe/IioCfgUpdateDxe/IioCfgUpdateDxe.c | 2 +- > .../Dxe/IioCfgUpdateDxe/IioCfgUpdateDxe.inf | 4 ++ > .../Dxe/SlotDataUpdateDxe/SlotDataUpdateDxe.c | 2 +- > .../SlotDataUpdateDxe/SlotDataUpdateDxe.inf | 2 + > .../Dxe/UsbOcUpdateDxe/UsbOcUpdateDxe.c | 2 +- > .../Dxe/UsbOcUpdateDxe/UsbOcUpdateDxe.inf | 1 + > .../TypeCooperCityRP/Pei/AcpiTablePcds.c | 4 +- > .../UbaMain/TypeCooperCityRP/Pei/PcdData.c | 3 +- > .../TypeCooperCityRP/Pei/PchEarlyUpdate.c | 2 +- > .../TypeCooperCityRP/Pei/PeiBoardInit.h | 11 +--- > .../TypeCooperCityRP/Pei/PeiBoardInitLib.c | 10 +++- > .../TypeCooperCityRP/Pei/PeiBoardInitLib.inf | 11 ++++ > .../Dxe/IioCfgUpdateDxe/IioCfgUpdateDxe.c | 2 +- > .../Dxe/IioCfgUpdateDxe/IioCfgUpdateDxe.inf | 6 +- > .../Dxe/SlotDataUpdateDxe/SlotDataUpdateDxe.c | 2 +- > .../SlotDataUpdateDxe/SlotDataUpdateDxe.inf | 3 +- > .../Dxe/UsbOcUpdateDxe/UsbOcUpdateDxe.c | 2 +- > .../Dxe/UsbOcUpdateDxe/UsbOcUpdateDxe.inf | 3 +- > .../TypeWilsonCityRP/Pei/AcpiTablePcds.c | 4 +- > .../TypeWilsonCityRP/Pei/IioBifurInit.c | 8 +-- > .../UbaMain/TypeWilsonCityRP/Pei/KtiEparam.c | 2 - > .../TypeWilsonCityRP/Pei/PchEarlyUpdate.c | 4 +- > .../TypeWilsonCityRP/Pei/PeiBoardInitLib.c | 4 +- > .../TypeWilsonCityRP/Pei/PeiBoardInitLib.inf | 11 ++++ > .../Dxe/IioCfgUpdateDxe/IioCfgUpdateDxe.c | 2 +- > .../Dxe/IioCfgUpdateDxe/IioCfgUpdateDxe.inf | 4 ++ > .../Dxe/SlotDataUpdateDxe/SlotDataUpdateDxe.c | 2 +- > .../SlotDataUpdateDxe/SlotDataUpdateDxe.inf | 1 + > .../Dxe/UsbOcUpdateDxe/UsbOcUpdateDxe.c | 2 +- > .../Dxe/UsbOcUpdateDxe/UsbOcUpdateDxe.inf | 1 + > .../TypeWilsonCitySMT/Pei/AcpiTablePcds.c | 4 +- > .../UbaMain/TypeWilsonCitySMT/Pei/GpioTable.c | 2 +- > .../TypeWilsonCitySMT/Pei/IioBifurInit.c | 8 +-- > .../UbaMain/TypeWilsonCitySMT/Pei/KtiEparam.c | 2 - > .../TypeWilsonCitySMT/Pei/PchEarlyUpdate.c | 6 +- > .../TypeWilsonCitySMT/Pei/PeiBoardInitLib.c | 2 +- > .../TypeWilsonCitySMT/Pei/PeiBoardInitLib.inf | 12 ++++ > .../PeiInterposerToSvidMap.c | 9 +-- > .../FspWrapperPlatformLib.c | 2 +- > .../SiliconPolicyInitLibShim.c | 8 +-- > 183 files changed, 510 insertions(+), 611 deletions(-) > > -- > 2.36.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#91607): https://edk2.groups.io/g/devel/message/91607 Mute This Topic: https://groups.io/mt/92099074/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-