Hi Kun, sorry for the late reply. The change is okay - thanks for making sure to change this platform, too!
Reviewed-by: Daniel Schaefer <daniel.schae...@hpe.com> Thanks, Daniel On 8/11/22 06:52, Kun Qin wrote: > Hi U5SeriesPkg maintainers, > > Can you please review the patch below and let me know if any feedback? > Platform build could be broken without this change. > > Any input is appreciated. > > Regards, > Kun > > On 8/4/2022 5:35 PM, Kun Qin via groups.io wrote: >> The new changes in SecureBootVariableLib brought in a new dependency >> of PlatformPKProtectionLib. >> >> This change added the new library instance from SecurityPkg to resolve >> U5SeriesPkg platforms build. >> >> Cc: Abner Chang <abner.ch...@hpe.com> >> Cc: Gilbert Chen <gilbert.c...@hpe.com> >> Cc: Daniel Schaefer <daniel.schae...@hpe.com> >> >> Signed-off-by: Kun Qin <kuqi...@gmail.com> >> --- >> >> Notes: >> v2: >> - No review, no change >> v4: >> - Updated commit title. >> >> Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc | 1 + >> Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc | 1 + >> 2 files changed, 2 insertions(+) >> >> diff --git a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc >> b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc >> index 7b36b2c885e0..fc1ed012a541 100644 >> --- a/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc >> +++ b/Platform/SiFive/U5SeriesPkg/FreedomU500VC707Board/U500.dsc >> @@ -127,6 +127,7 @@ [LibraryClasses] >> AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf >> >> >> SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf >> >> >> SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf >> >> + >> PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf >> >> !else >> >> >> TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf >> >> >> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf >> >> diff --git >> a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc >> b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc >> index 26895a75ec2f..e59955d09452 100644 >> --- a/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc >> +++ b/Platform/SiFive/U5SeriesPkg/FreedomU540HiFiveUnleashedBoard/U540.dsc >> @@ -127,6 +127,7 @@ [LibraryClasses] >> AuthVariableLib|SecurityPkg/Library/AuthVariableLib/AuthVariableLib.inf >> >> >> SecureBootVariableLib|SecurityPkg/Library/SecureBootVariableLib/SecureBootVariableLib.inf >> >> >> SecureBootVariableProvisionLib|SecurityPkg/Library/SecureBootVariableProvisionLib/SecureBootVariableProvisionLib.inf >> >> + >> PlatformPKProtectionLib|SecurityPkg/Library/PlatformPKProtectionLibVarPolicy/PlatformPKProtectionLibVarPolicy.inf >> >> !else >> >> >> TpmMeasurementLib|MdeModulePkg/Library/TpmMeasurementLibNull/TpmMeasurementLibNull.inf >> >> >> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf >> -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#92331): https://edk2.groups.io/g/devel/message/92331 Mute This Topic: https://groups.io/mt/92947607/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
