Hello OvmfPkg & FatPkg maintainers,

This series only needs a Reviewed-by from these packages. It should take less than a couple minutes of your time.

Thanks,
Michael

On 9/2/2022 6:21 PM, Michael Kubacki wrote:
From: Michael Kubacki <[email protected]>

After noticing a few occurrences of DEBUG macros with a mismatched
number of arguments, I wrote a script to automatically detect this.

This patch series is the result of matches found by the script.

In some cases it is not obvious what was originally intended so I
have attempted to capture what I believe was the original author's
intention.

V3 Changes:
Updated R-b tags.
1. ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c:
    - Repeated BufferSizeInBytes argument per Leif's feedback
2. MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.c:
    - Fixed an additional error on Line 267

V2 Changes:
These additional errors were found while finishing testing of
the script.

1. Add DynamicTablesPkg/AcpiPpttLibArm patch for the change in
    - DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c
2. Update MdeModulePkg patch to include the change in
    - MdeModulePkg/Universal/CapsulePei/UefiCapsule.c
3. Add following to the RedfishPkg fix patch:
    - RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c
    - RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c
4. Add NetworkPkg patch for the change in
    - NetworkPkg/TcpDxe/SockInterface.c
5. Add OvmfPkg patch for the change in
    - OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c

Cc: Abner Chang <[email protected]>
Cc: Alexei Fedorov <[email protected]>
Cc: Ard Biesheuvel <[email protected]>
Cc: Dandan Bi <[email protected]>
Cc: David Woodhouse <[email protected]>
Cc: Gerd Hoffmann <[email protected]>
Cc: Guomin Jiang <[email protected]>
Cc: Hao A Wu <[email protected]>
Cc: Jian J Wang <[email protected]>
Cc: Jiaxin Wu <[email protected]>
Cc: Jiewen Yao <[email protected]>
Cc: Jordan Justen <[email protected]>
Cc: Leif Lindholm <[email protected]>
Cc: Liming Gao <[email protected]>
Cc: Maciej Rabeda <[email protected]>
Cc: Nickle Wang <[email protected]>
Cc: Qi Zhang <[email protected]>
Cc: Rahul Kumar <[email protected]>
Cc: Ray Ni <[email protected]>
Cc: Sami Mujawar <[email protected]>
Cc: Siyuan Fu <[email protected]>
Signed-off-by: Michael Kubacki <[email protected]>

Michael Kubacki (8):
   ArmPlatformPkg/NorFlashDxe: Remove unused debug print specifier
   FatPkg/FatPei: Remove extraneous debug message argument
   MdeModulePkg: Fix imbalanced debug macros
   RedfishPkg/RedfishRestExDxe: Remove extra debug macro argument
   SecurityPkg/SmmTcg2PhysicalPresenceLib: Add missing debug print
     specifier
   DynamicTablesPkg/AcpiPpttLibArm: Fix debug macro arguments
   NetworkPkg/TcpDxe: Fix debug macro arguments
   OvmfPkg/LegacyBootManagerLib: Fix debug macro arguments

  ArmPlatformPkg/Drivers/NorFlashDxe/NorFlashBlockIoDxe.c                       
           |  4 ++--
  DynamicTablesPkg/Library/Acpi/Arm/AcpiPpttLibArm/PpttGenerator.c              
           |  3 +--
  FatPkg/FatPei/Gpt.c                                                           
           |  2 +-
  MdeModulePkg/Bus/Pci/NvmExpressPei/NvmExpressPei.c                            
           |  2 +-
  MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c                              
           |  2 +-
  MdeModulePkg/Bus/Usb/UsbBusDxe/UsbEnumer.c                                    
           |  8 ++++----
  MdeModulePkg/Core/Dxe/Image/Image.c                                           
           |  2 +-
  
MdeModulePkg/Library/DisplayUpdateProgressLibGraphics/DisplayUpdateProgressLibGraphics.c
 |  2 +-
  MdeModulePkg/Universal/CapsulePei/UefiCapsule.c                               
           |  2 +-
  NetworkPkg/TcpDxe/SockInterface.c                                             
           | 12 ++----------
  OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c                                   
           |  6 +++---
  RedfishPkg/RedfishDiscoverDxe/RedfishDiscoverDxe.c                            
           |  6 +++---
  RedfishPkg/RedfishHostInterfaceDxe/RedfishHostInterfaceDxe.c                  
           |  2 +-
  RedfishPkg/RedfishRestExDxe/RedfishRestExProtocol.c                           
           |  2 +-
  
SecurityPkg/Library/SmmTcg2PhysicalPresenceLib/MmTcg2PhysicalPresenceLibCommon.c
         |  2 +-
  15 files changed, 24 insertions(+), 33 deletions(-)



-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#93113): https://edk2.groups.io/g/devel/message/93113
Mute This Topic: https://groups.io/mt/93429907/21656
Group Owner: [email protected]
Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-


Reply via email to