Hi Benjamin, I have provided some comments for you on patches 2 and 3. In addition, please rebase this patch series with latest as there has been some changes since my initial patch series from June.
Thanks, Nate > -----Original Message----- > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of > Benjamin Doron > Sent: Tuesday, September 6, 2022 10:27 AM > To: devel@edk2.groups.io > Subject: [edk2-devel][edk2-platforms][PATCH v1 0/3] > > Enable the HDMI debug port to be used for SEC phase debug. Commit my > build configuration, which successfully ouputs debug messages in all phases > and boot-flows: SEC, PEI, DXE and SMM, with handling for the special case > that is BootScriptExecutorDxe. > > This patch series comprises the work product for my second planned GSoC > 2022 project. > > These are enhancements to Nate's series here: > https://edk2.groups.io/g/devel/message/90591. > > Benjamin Doron (3): > > MinPlatformPkg,WhiskeylakeOpenBoardPkg/SecFspWrapperPlatformSecLib: > First BoardInitLib > [WIP] KabylakeOpenBoardPkg/I2cHdmiDebugSerialPortLib: Commit local > KabylakeOpenBoardPkg/AspireVn7Dash572G: Hook-up HDMI debug port to > build > > .../AspireVn7Dash572G/OpenBoardPkg.dsc | 85 +++++++++++++---- > .../AspireVn7Dash572G/OpenBoardPkg.fdf | 11 +-- > .../AspireVn7Dash572G/OpenBoardPkgPcd.dsc | 54 ++++++++++- > ...ptExecutorDxeI2cHdmiDebugSerialPortLib.inf | 48 ++++++++++ > .../DxeI2cHdmiDebugSerialPortLib.inf | 8 +- > .../DxeSmmI2cHdmiDebugSerialPortLib.c | 2 - > .../Library/I2cHdmiDebugSerialPortLib/Gmbus.c | 39 ++++---- > .../I2cDebugPortProtocol.c | 2 - > .../I2cDebugPortTplDxe.c | 9 ++ > .../I2cDebugPortTplRuntimeDxe.c | 93 +++++++++++++++++++ > .../I2cHdmiDebugSerialPortLib.c | 3 - > .../I2cHdmiDebugSerialPortLib/IgfxI2c.c | 9 +- > .../PeiI2cHdmiDebugSerialPortLib.c | 1 - > .../PeiI2cHdmiDebugSerialPortLib.inf | 5 +- > .../RuntimeDxeI2cHdmiDebugSerialPortLib.inf | 51 ++++++++++ > .../SecI2cHdmiDebugSerialPortLib.c | 1 - > .../SecI2cHdmiDebugSerialPortLib.inf | 7 +- > .../SmmI2cHdmiDebugSerialPortLib.inf | 6 +- > .../PlatformInit.c | 8 +- > .../PlatformInit.c | 8 +- > 20 files changed, 364 insertions(+), 86 deletions(-) create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/Library/I2cHdmiDebugSerialPortLib/ > BootScriptExecutorDxeI2cHdmiDebugSerialPortLib.inf > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/Library/I2cHdmiDebugSerialPortLib/I > 2cDebugPortTplRuntimeDxe.c > create mode 100644 > Platform/Intel/KabylakeOpenBoardPkg/Library/I2cHdmiDebugSerialPortLib/ > RuntimeDxeI2cHdmiDebugSerialPortLib.inf > > -- > 2.37.2 > > > > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#93617): https://edk2.groups.io/g/devel/message/93617 Mute This Topic: https://groups.io/mt/93506699/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
