Reviewed-by: Nate DeSimone <[email protected]> -----Original Message----- From: Chiu, Chasel <[email protected]> Sent: Tuesday, October 4, 2022 1:34 PM To: [email protected] Cc: Chiu, Chasel <[email protected]>; Desimone, Nathaniel L <[email protected]>; Zeng, Star <[email protected]> Subject: [PATCH] IntelFsp2WrapperPkg: Add header for PlatformMultiPhaseLib.
REF: https://bugzilla.tianocore.org/show_bug.cgi?id=4092 To comply with coding style rule each library class should have its own header even if it is just a private child library instance consumed by parent public library in the same package. Cc: Nate DeSimone <[email protected]> Cc: Star Zeng <[email protected]> Signed-off-by: Chasel Chiu <[email protected]> --- IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWrapperMultiPhaseProcessLib.c | 2 +- IntelFsp2WrapperPkg/Include/Library/FspWrapperMultiPhaseProcessLib.h | 18 ------------------ IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformMultiPhaseLib.h | 30 ++++++++++++++++++++++++++++++ IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec | 2 +- 4 files changed, 32 insertions(+), 20 deletions(-) diff --git a/IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWrapperMultiPhaseProcessLib.c b/IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWrapperMultiPhaseProcessLib.c index 3ddc07690a..1248accf87 100644 --- a/IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspWrapperMultiPhaseProcessLib.c +++ b/IntelFsp2WrapperPkg/Library/FspWrapperMultiPhaseProcessLib/PeiFspW +++ rapperMultiPhaseProcessLib.c @@ -16,7 +16,7 @@ #include <Ppi/ReadOnlyVariable2.h> #include <Ppi/Variable.h> #include <Library/PeiServicesLib.h>-#include <Library/FspWrapperMultiPhaseProcessLib.h>+#include <Library/FspWrapperPlatformMultiPhaseLib.h> /** Execute 32-bit FSP API entry code.diff --git a/IntelFsp2WrapperPkg/Include/Library/FspWrapperMultiPhaseProcessLib.h b/IntelFsp2WrapperPkg/Include/Library/FspWrapperMultiPhaseProcessLib.h index 65a5db233f..aadacc9b50 100644 --- a/IntelFsp2WrapperPkg/Include/Library/FspWrapperMultiPhaseProcessLib.h +++ b/IntelFsp2WrapperPkg/Include/Library/FspWrapperMultiPhaseProcessLib +++ .h @@ -9,24 +9,6 @@ #ifndef __FSP_WRAPPER_MULTI_PHASE_PROCESS_LIB_H__ #define __FSP_WRAPPER_MULTI_PHASE_PROCESS_LIB_H__ -/**- FSP Wrapper Platform MultiPhase Handler-- @param[in] FspHobListPtr - Pointer to FSP HobList (valid after FSP-M completed)- @param[in] ComponentIndex - FSP Component which executing MultiPhase initialization.- @param[in] PhaseIndex - Indicates current execution phase of FSP MultiPhase initialization.-- @retval EFI_STATUS Always return EFI_SUCCESS--**/-VOID-EFIAPI-FspWrapperPlatformMultiPhaseHandler (- IN OUT VOID **FspHobListPtr,- IN UINT8 ComponentIndex,- IN UINT32 PhaseIndex- );- /** FSP Wrapper Variable Request Handler diff --git a/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformMultiPhaseLib.h b/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformMultiPhaseLib.h new file mode 100644 index 0000000000..79b5ba0ec3 --- /dev/null +++ b/IntelFsp2WrapperPkg/Include/Library/FspWrapperPlatformMultiPhaseLi +++ b.h @@ -0,0 +1,30 @@ +/** @file+ Provide FSP wrapper Platform MultiPhase handling functions.++ Copyright (c) 2022, Intel Corporation. All rights reserved.<BR>+ SPDX-License-Identifier: BSD-2-Clause-Patent++**/++#ifndef __FSP_WRAPPER_PLATFORM_MULTI_PHASE_PROCESS_LIB_H__+#define __FSP_WRAPPER_PLATFORM_MULTI_PHASE_PROCESS_LIB_H__++/**+ FSP Wrapper Platform MultiPhase Handler++ @param[in] FspHobListPtr - Pointer to FSP HobList (valid after FSP-M completed)+ @param[in] ComponentIndex - FSP Component which executing MultiPhase initialization.+ @param[in] PhaseIndex - Indicates current execution phase of FSP MultiPhase initialization.++ @retval EFI_STATUS Always return EFI_SUCCESS++**/+VOID+EFIAPI+FspWrapperPlatformMultiPhaseHandler (+ IN OUT VOID **FspHobListPtr,+ IN UINT8 ComponentIndex,+ IN UINT32 PhaseIndex+ );++#endifdiff --git a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec index 95ada0f7a1..922ccc063f 100644 --- a/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec +++ b/IntelFsp2WrapperPkg/IntelFsp2WrapperPkg.dec @@ -33,7 +33,7 @@ FspWrapperMultiPhaseProcessLib|Include/Library/FspWrapperMultiPhaseProcessLib.h ## @libraryclass Provide MultiPhase platform actions related functions.- FspWrapperPlatformMultiPhaseLib|Include/Library/FspWrapperMultiPhaseProcessLib.h+ FspWrapperPlatformMultiPhaseLib|Include/Library/FspWrapperPlatformMultiPhaseLib.h [Guids]-- 2.35.0.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94723): https://edk2.groups.io/g/devel/message/94723 Mute This Topic: https://groups.io/mt/94122844/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
