Reviewed-by: Ashraf Ali S <[email protected]> Regards, Ashraf Ali S Intel Technology India Pvt. Ltd.
-----Original Message----- From: [email protected] <[email protected]> On Behalf Of Michael Kubacki Sent: Wednesday, October 5, 2022 8:53 PM To: [email protected] Cc: S, Ashraf Ali <[email protected]>; Oram, Isaac W <[email protected]>; Chaganty, Rangasai V <[email protected]>; Ni, Ray <[email protected]> Subject: [edk2-devel] [edk2-platforms][PATCH v1 1/1] IntelSiliconPkg/SpiFvbService: Read FV header length from header From: Michael Kubacki <[email protected]> Bug Fix: Read the FV header length from the Firmware Volume Block (FVB) information structure as opposed to EFI_FIRMWARE_VOLUME_HEADER to account for a variable number of block map entries. Cc: Ashraf Ali S <[email protected]> Cc: Isaac Oram <[email protected]> Cc: Rangasai V Chaganty <[email protected]> Cc: Ray Ni <[email protected]> Signed-off-by: Michael Kubacki <[email protected]> --- Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/FvbInfo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/FvbInfo.c b/Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/FvbInfo.c index 634a44218c7a..ab1cb2ef1622 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/FvbInfo.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/Flash/SpiFvbService/FvbInfo. +++ c @@ -115,7 +115,7 @@ GetFvbInfo ( Status = mFvbMediaInfoGenerators[Index](&FvbMediaInfo); ASSERT_EFI_ERROR (Status); if (!EFI_ERROR (Status) && (FvbMediaInfo.BaseAddress == FvBaseAddress)) { - FvHeader = AllocateCopyPool (sizeof (EFI_FIRMWARE_VOLUME_HEADER), &FvbMediaInfo.FvbInfo); + FvHeader = AllocateCopyPool (FvbMediaInfo.FvbInfo.HeaderLength, + &FvbMediaInfo.FvbInfo); // // Update the checksum value of FV header. -- 2.28.0.windows.1 -=-=-=-=-=-= Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94758): https://edk2.groups.io/g/devel/message/94758 Mute This Topic: https://groups.io/mt/94137814/6226280 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-= -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#94939): https://edk2.groups.io/g/devel/message/94939 Mute This Topic: https://groups.io/mt/94137814/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
