Michael: For BaseTools, MdePkg, and MdeModulePkg, the changes are good to me. Reviewed-by: Liming Gao <gaolim...@byosoft.com.cn>
Thanks Liming > -----邮件原件----- > 发件人: Michael Kubacki <mikub...@linux.microsoft.com> > 发送时间: 2022年11月15日 23:00 > 收件人: devel@edk2.groups.io > 抄送: Bob Feng <bob.c.f...@intel.com>; Dandan Bi <dandan...@intel.com>; > Eric Dong <eric.d...@intel.com>; Erich McMillan > <emcmil...@microsoft.com>; Guomin Jiang <guomin.ji...@intel.com>; Jian J > Wang <jian.j.w...@intel.com>; Jiaxin Wu <jiaxin...@intel.com>; Jiewen Yao > <jiewen....@intel.com>; Liming Gao <gaolim...@byosoft.com.cn>; Maciej > Rabeda <maciej.rab...@linux.intel.com>; Michael D Kinney > <michael.d.kin...@intel.com>; Rahul Kumar <rahul1.ku...@intel.com>; > Ray Ni <ray...@intel.com>; Sean Brogan <sean.bro...@microsoft.com>; > Siyuan Fu <siyuan...@intel.com>; Star Zeng <star.z...@intel.com>; Xiaoyu Lu > <xiaoyu1...@intel.com>; Yuwei Chen <yuwei.c...@intel.com>; Zhichao Gao > <zhichao....@intel.com>; Zhiguang Liu <zhiguang....@intel.com> > 主题: Re: [edk2-devel] [PATCH v1 00/12] Enable New CodeQL Queries > > Maintainers/reviewers, > > This is an important series for us to make progress on enabling CodeQL > and needs cooperation from maintainers across several packages. > > I have not received any feedback yet. > > Most of these patches should not take long to review. Please help review > your patches so we can continue forward momentum on enabling code > scanning in the repo. > > Thanks, > Michael > > On 11/9/2022 12:32 PM, Michael Kubacki wrote: > > From: Michael Kubacki <michael.kuba...@microsoft.com> > > > > Adds queries for the following: > > > > 1. cpp/conditionallyuninitializedvariable > > 2. cpp/pointer-overflow-check > > 3. cpp/overrunning-write > > 4. cpp/overrunning-write-with-float > > 5. cpp/very-likely-overrunning-write > > > > These check for vulnerabilities with the following CWEs: > > > > - https://cwe.mitre.org/data/definitions/120.html > > - https://cwe.mitre.org/data/definitions/457.html > > - https://cwe.mitre.org/data/definitions/676.html > > - https://cwe.mitre.org/data/definitions/758.html > > - https://cwe.mitre.org/data/definitions/787.html > > - https://cwe.mitre.org/data/definitions/805.html > > > > The first part of this patch series contains fixes for CodeQL alerts > > across various packages that are produced by the new queries being > > enabled. > > > > The second part updates the CodeQL queries. > > > > Cc: Bob Feng <bob.c.f...@intel.com> > > Cc: Dandan Bi <dandan...@intel.com> > > Cc: Eric Dong <eric.d...@intel.com> > > Cc: Erich McMillan <emcmil...@microsoft.com> > > Cc: Guomin Jiang <guomin.ji...@intel.com> > > Cc: Jian J Wang <jian.j.w...@intel.com> > > Cc: Jiaxin Wu <jiaxin...@intel.com> > > Cc: Jiewen Yao <jiewen....@intel.com> > > Cc: Liming Gao <gaolim...@byosoft.com.cn> > > Cc: Maciej Rabeda <maciej.rab...@linux.intel.com> > > Cc: Michael D Kinney <michael.d.kin...@intel.com> > > Cc: Michael Kubacki <mikub...@linux.microsoft.com> > > Cc: Rahul Kumar <rahul1.ku...@intel.com> > > Cc: Ray Ni <ray...@intel.com> > > Cc: Sean Brogan <sean.bro...@microsoft.com> > > Cc: Siyuan Fu <siyuan...@intel.com> > > Cc: Star Zeng <star.z...@intel.com> > > Cc: Xiaoyu Lu <xiaoyu1...@intel.com> > > Cc: Yuwei Chen <yuwei.c...@intel.com> > > Cc: Zhichao Gao <zhichao....@intel.com> > > Cc: Zhiguang Liu <zhiguang....@intel.com> > > Signed-off-by: Michael Kubacki <michael.kuba...@microsoft.com> > > > > Erich McMillan (1): > > MdeModulePkg/SmbiosDxe: Fix pointer and buffer overflow CodeQL > alerts > > > > Michael Kubacki (11): > > BaseTools/PatchCheck.py: Add PCCTS to tab exemption list > > BaseTools/VfrCompile: Fix potential buffer overwrites > > CryptoPkg: Fix conditionally uninitialized variable > > MdeModulePkg: Fix conditionally uninitialized variables > > MdePkg: Fix conditionally uninitialized variables > > NetworkPkg: Fix conditionally uninitialized variables > > PcAtChipsetPkg: Fix conditionally uninitialized variables > > ShellPkg: Fix conditionally uninitialized variables > > UefiCpuPkg: Fix conditionally uninitialized variables > > .github/codeql/edk2.qls: Enable CWE 457, 676, and 758 queries > > .github/codeql/edk2.qls: Enable CWE 120, 787, and 805 queries > > > > BaseTools/Source/C/VfrCompile/Pccts/antlr/gen.c | > 10 ++-- > > BaseTools/Source/C/VfrCompile/Pccts/antlr/main.c | > 4 +- > > CryptoPkg/Library/BaseCryptLib/Pk/CryptX509.c | > 21 ++++---- > > MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c > | 5 +- > > MdeModulePkg/Bus/Pci/UhciDxe/Uhci.c > | 24 +++++---- > > MdeModulePkg/Core/Dxe/Mem/Page.c > | 17 +++--- > > MdeModulePkg/Library/BootMaintenanceManagerUiLib/BootOption.c | > 25 +++++---- > > MdeModulePkg/Library/FileExplorerLib/FileExplorer.c | 5 > +- > > MdeModulePkg/Universal/BdsDxe/BdsEntry.c > | 33 ++++++------ > > MdeModulePkg/Universal/DisplayEngineDxe/ProcessOptions.c | > 11 ++-- > > MdeModulePkg/Universal/HiiDatabaseDxe/Font.c > | 14 +++-- > > MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.c > | 4 +- > > MdeModulePkg/Universal/Variable/RuntimeDxe/Variable.c | > 2 +- > > MdePkg/Library/BaseLib/String.c > | 20 ++++--- > > NetworkPkg/Library/DxeHttpLib/DxeHttpLib.c | > 2 +- > > NetworkPkg/TcpDxe/TcpInput.c > | 3 ++ > > PcAtChipsetPkg/PcatRealTimeClockRuntimeDxe/PcRtc.c | > 9 ++-- > > ShellPkg/Application/Shell/Shell.c | > 2 +- > > ShellPkg/Application/Shell/ShellProtocol.c | 4 > +- > > ShellPkg/Library/UefiShellCommandLib/UefiShellCommandLib.c | > 56 +++++++++++--------- > > ShellPkg/Library/UefiShellDebug1CommandsLib/Dblk.c | > 18 ++++--- > > ShellPkg/Library/UefiShellDebug1CommandsLib/EfiDecompress.c | > 9 ++-- > > ShellPkg/Library/UefiShellDriver1CommandsLib/Connect.c | 14 > ++--- > > ShellPkg/Library/UefiShellDriver1CommandsLib/Disconnect.c | 17 > +++--- > > ShellPkg/Library/UefiShellDriver1CommandsLib/DrvDiag.c | 21 > ++++---- > > UefiCpuPkg/CpuMpPei/CpuBist.c > | 8 ++- > > UefiCpuPkg/CpuMpPei/CpuMpPei.c > | 8 ++- > > UefiCpuPkg/CpuMpPei/CpuPaging.c > | 9 +++- > > .github/codeql/edk2.qls > | 10 ++++ > > BaseTools/Scripts/PatchCheck.py > | 4 +- > > MdeModulePkg/Universal/SmbiosDxe/SmbiosDxe.inf > | 1 + > > 31 files changed, 238 insertions(+), 152 deletions(-) > > -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96411): https://edk2.groups.io/g/devel/message/96411 Mute This Topic: https://groups.io/mt/95058061/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
