Reviewed-by: S, Ashraf Ali <[email protected]> Regards, Ashraf Ali S Intel Technology India Pvt. Ltd.
-----Original Message----- From: Kinney, Michael D <[email protected]> Sent: Wednesday, November 16, 2022 1:54 PM To: [email protected] Cc: Ni, Ray <[email protected]>; Chaganty, Rangasai V <[email protected]>; Oram, Isaac W <[email protected]>; S, Ashraf Ali <[email protected]> Subject: [Patch] IntelSiliconPkg/IntelVTdDmarPei: Fix CLANG detected incorrect return CreateSecondLevelPagingEntryTable() has a return type of VTD_SECOND_LEVEL_PAGING_ENTRY * and an error condition returns a value of NULL. Change return value of EFI_SUCCESS (value 0) to NULL to address CLANG compiler detection of incorrect return type. Cc: Ray Ni <[email protected]> Cc: Rangasai V Chaganty <[email protected]> Cc: Isaac Oram <[email protected]> Cc: Ashraf Ali S <[email protected]> Signed-off-by: Michael D Kinney <[email protected]> --- .../Feature/VTd/IntelVTdDmarPei/TranslationTable.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/TranslationTable.c b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/TranslationTable.c index a806c4c000..bb121a608e 100644 --- a/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/TranslationTable.c +++ b/Silicon/Intel/IntelSiliconPkg/Feature/VTd/IntelVTdDmarPei/Translat +++ ionTable.c @@ -109,7 +109,7 @@ CreateSecondLevelPagingEntryTable ( BOOLEAN Is5LevelPaging; if (MemoryLimit == 0) { - return EFI_SUCCESS; + return NULL; } Lvl4PagesStart = 0; -- 2.37.1.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96426): https://edk2.groups.io/g/devel/message/96426 Mute This Topic: https://groups.io/mt/95062535/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
