The code change looks fine to me. But I would adjust the commit message when I send the PR. Reviewed-by: Zhichao Gao <[email protected]>
Thanks, Zhichao > -----Original Message----- > From: Zhang, JuX <[email protected]> > Sent: Wednesday, November 16, 2022 3:13 PM > To: [email protected] > Cc: Gao, Zhichao <[email protected]>; Wu, Jiaxin <[email protected]> > Subject: [PATCH] ShellPkg: Update ProcessorUpgradeTable REF: > https://bugzilla.tianocore.org/show_bug.cgi?id=4156 > > Refer to the latest SMBIOS v3.6, SMBIOS Socket not completely defined. > > SMBIOS v3.6: > https://www.dmtf.org/sites/default/files/standards/documents/DSP0134_3. > 6.0.pdf > > Signed-off-by: JuX Zhang <[email protected]> > Cc: Zhichao Gao <[email protected]> > Cc: Jiaxin Wu <[email protected]> > --- > .../SmbiosView/QueryTable.c | 36 +++++++++++++++++++ > 1 file changed, 36 insertions(+) > > diff --git > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > c > index 2e62ae3a34f8..edb46817e422 100644 > --- > a/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable.c > +++ > b/ShellPkg/Library/UefiShellDebug1CommandsLib/SmbiosView/QueryTable. > c > @@ -601,6 +601,42 @@ TABLE_ITEM ProcessorUpgradeTable[] = { > { > > 0x3F, > > L"Socket LGA4677" > > + }, > > + { > > + 0x40, > > + L"Socket LGA1700" > > + }, > > + { > > + 0x41, > > + L"Socket BGA1744" > > + }, > > + { > > + 0x42, > > + L"Socket BGA1781" > > + }, > > + { > > + 0x43, > > + L"Socket BGA1211" > > + }, > > + { > > + 0x44, > > + L"Socket BGA2422" > > + }, > > + { > > + 0x45, > > + L"Socket LGA1211" > > + }, > > + { > > + 0x46, > > + L"Socket LGA2422" > > + }, > > + { > > + 0x47, > > + L"Socket LGA5773" > > + }, > > + { > > + 0x48, > > + L"Socket BGA5773" > > } > > }; > > > > -- > 2.26.2.windows.1 -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96441): https://edk2.groups.io/g/devel/message/96441 Mute This Topic: https://groups.io/mt/95067602/21656 Group Owner: [email protected] Unsubscribe: https://edk2.groups.io/g/devel/unsub [[email protected]] -=-=-=-=-=-=-=-=-=-=-=-
