Sean,
Quoting Sean Brogan (2022-11-30 01:28:45) > Oliver, > > Thanks for this changeset and i think this is getting closer but over the past > few months there have been a few changes that I don't think this series takes > into account. > > A few comments i hope we can address quickly (since 18.04 is going offline > tomorrow). > > 1. Can the whole block at [1]https://github.com/tianocore/edk2/blob/ > dd3ba82d31a6d3cc4564dc83c9229e13773b55da/.pytool/CISettings.py#L172 be > removed. The only reason these exist is to pick up and download the > compilers. Yes. Done. > > 2. what about supporting the loongarch64 compiler? Can we add to container? Added the gcc release from the LoongSon GitHub page. This is a 13.0.0 20220906 (experimental), and not yet available via regular repositories. I opted for the "c-only" package which is only 70MB instead of the "full" one which was used in the ext_dep file (921MB). > > 3. If loongarch64 is included in container should you delete this file too: > [2] > edk2/gcc_loongarch64_unknown_linux_ext_dep.yaml at master tianocore/edk2 > (github.com) > Deleted. > 4. Patch 4 has changes in multiple packages. I believe it is a requirement > in > edk2 to only change a single package per commit. It makes reviews and > cherry-picking/bisection easier. Commit is now split by package. > 5. Since only Core CI as controlled by file .azurepipelines/Ubuntu_GCC5.yml > why not use the base container instead of test container? The Core CI Process > will not use qemu. The platform Ci files have their own yml with container > specifier. Changed. > > 6. what about removing the steps for installing node and cspell from the > container build? Since these are managed in the container they should be > skipped. I do not know what exactly what is was added for. I'll open an issue on the containers github for that. I think this is not critical at the moment. We can still thin out the image after tomorrow. > > Thanks > > Sean > We'll need to merge the changes for the docker file and let the new image be generated. Then I can prepare the next version of the patches. Thanks, Oliver -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#96742): https://edk2.groups.io/g/devel/message/96742 Mute This Topic: https://groups.io/mt/95342427/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
