Yes. I am not sure if the preference for modules in other packages. But for code in UefiCpuPkg, I don't prefer this way.
Thanks, Ray > -----Original Message----- > From: Sunil V L <suni...@ventanamicro.com> > Sent: Thursday, December 8, 2022 12:58 PM > To: devel@edk2.groups.io; Ni, Ray <ray...@intel.com> > Cc: Wang, Jian J <jian.j.w...@intel.com>; Gao, Liming > <gaolim...@byosoft.com.cn>; Dong, Eric <eric.d...@intel.com>; Kumar, > Rahul R <rahul.r.ku...@intel.com>; De, Debkumar > <debkumar...@intel.com>; West, Catharine <catharine.w...@intel.com>; > Daniel Schaefer <g...@danielschaefer.me>; Abner Chang > <abner.ch...@amd.com>; Leif Lindholm <quic_llind...@quicinc.com>; > Andrew Fish <af...@apple.com>; Ard Biesheuvel <a...@kernel.org>; > Heinrich Schuchardt <heinrich.schucha...@canonical.com>; Anup Patel > <apa...@ventanamicro.com> > Subject: Re: [edk2-devel] [RFC PATCH V2 10/19] UefiCpuPkg: Add RISC-V > support in DxeCpuExceptionHandlerLib > > On Thu, Dec 08, 2022 at 12:30:04AM +0000, Ni, Ray wrote: > > Sunil, > > Is there any source code sharing between Risc-V and IA32X64? > > From the patch, I cannot see any. > > If that's the case, I would prefer we don't mix the two separate > implementations together into one component. > > Can you please create a new CpuExceptionHandlerLib instance for Risc-V > instead of including the Risc-V sources into the existing INF? > > > Thank you very much Ray. Sure. That approach is also fine with me. > > BTW, https://edk2.groups.io/g/devel/message/95726 was the latest series. > Sorry for the confusion. Let me update this series and send new version. > I think your input is valid for other modules also like TimerLib. > > Thanks > Sunil -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#97132): https://edk2.groups.io/g/devel/message/97132 Mute This Topic: https://groups.io/mt/93522716/21656 Group Owner: devel+ow...@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [arch...@mail-archive.com] -=-=-=-=-=-=-=-=-=-=-=-
